[GitHub] [carbondata] kumarvishal09 commented on a change in pull request #3419: [CARBONDATA-3555] Make move filter related methods under DataMapFilter

[GitBox]

kumarvishal09 commented on a change in pull request #3419: [CARBONDATA-3555] Make move filter related methods under DataMapFilter
URL: https://github.com/apache/carbondata/pull/3419#discussion_r346742464
 
 

 ##########
 File path: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableInputFormat.java
 ##########
 @@ -174,15 +174,18 @@
             readCommittedScope);
 
     // process and resolve the expression
-    Expression filter = getFilterPredicates(job.getConfiguration());
+    DataMapFilter dataMapFilter = getFilterPredicates(job.getConfiguration());
     // this will be null in case of corrupt schema file.
     PartitionInfo partitionInfo = carbonTable.getPartitionInfo(carbonTable.getTableName());
 
+    if (dataMapFilter != null) {
+      dataMapFilter.resolve(false);
 
 Review comment:
   In data map filter class add a method which will resolve and process

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services