[GitHub] [carbondata] kumarvishal09 commented on a change in pull request #3419: [CARBONDATA-3555] Make move filter related methods under DataMapFilter

[GitBox]

kumarvishal09 commented on a change in pull request #3419: [CARBONDATA-3555] Make move filter related methods under DataMapFilter
URL: https://github.com/apache/carbondata/pull/3419#discussion_r346746575
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/scan/executor/impl/AbstractQueryExecutor.java
 ##########
 @@ -329,18 +329,12 @@ private void updateColumns(QueryModel queryModel, List<ColumnSchema> columnsInTa
   }
 
   private void createFilterExpression(QueryModel queryModel, SegmentProperties properties) {
-    Expression expression = queryModel.getFilterExpression();
-    if (expression != null) {
-      QueryModel.FilterProcessVO processVO = new QueryModel.FilterProcessVO(
-          properties.getDimensions(),
-          properties.getMeasures(),
-          new ArrayList<CarbonDimension>());
-      QueryModel.processFilterExpression(processVO, expression, null, null, queryModel.getTable());
-      // Optimize Filter Expression and fit RANGE filters is conditions apply.
-      FilterOptimizer rangeFilterOptimizer = new RangeFilterOptmizer(expression);
-      rangeFilterOptimizer.optimizeFilter();
-      queryModel.setFilterExpressionResolverTree(
-          CarbonTable.resolveFilter(expression, queryModel.getAbsoluteTableIdentifier()));
+    if (queryModel.getDataMapFilter() != null) {
 
 Review comment:
   Can u please revisit this code

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services