[GitHub] [carbondata] kumarvishal09 commented on a change in pull request #3444: [CARBONDATA-3581] Support page level bloom filter

[GitBox]

kumarvishal09 commented on a change in pull request #3444: [CARBONDATA-3581] Support page level bloom filter
URL: https://github.com/apache/carbondata/pull/3444#discussion_r349025076
 
 

 ##########
 File path: processing/src/main/java/org/apache/carbondata/processing/store/TablePage.java
 ##########
 @@ -104,6 +105,16 @@
     noDictDimensionPages = new ColumnPage[model.getNoDictionaryCount()];
     int tmpNumDictDimIdx = 0;
     int tmpNumNoDictDimIdx = 0;
+
+    // find columns config to build page bloom
+    List<String> pageBloomColumns = new ArrayList<>();
 
 Review comment:
   No need to keep this new list to store bloom information. Instead in `DimensionSpec `and `MeasureSpec` add a flag for isBloomPage

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services