[GitHub] [carbondata] kumarvishal09 commented on a change in pull request #3444: [CARBONDATA-3581] Support page level bloom filter

[GitBox]

kumarvishal09 commented on a change in pull request #3444: [CARBONDATA-3581] Support page level bloom filter
URL: https://github.com/apache/carbondata/pull/3444#discussion_r349031607
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java
 ##########
 @@ -3158,6 +3158,28 @@ private static int unsetLocalDictForComplexColumns(List<ColumnSchema> allColumns
     return columnLocalDictGenMap;
   }
 
+
+  public static void setPageBloomColumnsToWrapperSchema(List<ColumnSchema> columns,
+        Map<String, String> mainTableProperties) {
+    if (!mainTableProperties.containsKey(CarbonCommonConstants.PAGE_BLOOM_INCLUDE)) {
 
 Review comment:
   here checking contains and down calling .get method, instead just call get method and validate for null

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services