kumarvishal09 commented on a change in pull request #3444: [CARBONDATA-3581] Support page level bloom filter
URL:
https://github.com/apache/carbondata/pull/3444#discussion_r349051466
##########
File path: format/src/main/thrift/carbondata.thrift
##########
@@ -151,8 +151,16 @@ struct DataChunk3{
2: optional list<i32> page_offset; // Offset of each chunk
3: optional list<i32> page_length; // Length of each chunk
4: optional LocalDictionaryChunk local_dictionary; // to store blocklet local dictionary values
-
+ 5: optional PageBloomChunk page_bloom_chunk; // data of hash function and bitmaps of each page
}
+
+ struct PageBloomChunk{
+ 1: required i32 vector_size;
+ 2: required i16 num_hash;
+ 3: required i16 hash_type;
+ 4: required list<binary> pagebloom_list;
Review comment:
can u please write comment, And here one element in list represents one page bloom data ??
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]
With regards,
Apache Git Services
Locked
