[GitHub] [carbondata] kumarvishal09 opened a new pull request #4058: [CARBONDATA-4084]Fixed data corruption issue after fallback of Local dictionary

[GitBox]

kumarvishal09 opened a new pull request #4058:
URL: https://github.com/apache/carbondata/pull/4058


    ### Why is this PR needed?
    Data is getting corrupted when fallback happens for local dictionary encoded page.
   
    ### What changes were proposed in this PR?
   In LVByteBufferColumnPage Length getting added inside put method. In case of fallback when reverse lookup is done and encoded page is replaced with actual value[Dictionary values]. As actual Dictionary value is already present in LV format again one more length is getting added[LLV], so during query it's showing extra character for those columns
       
    ### Does this PR introduce any user interface change?
    - No
   
   
    ### Is any new testcase added?
    - No
   
   
       
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA2 commented on pull request #4058:
URL: https://github.com/apache/carbondata/pull/4058#issuecomment-748037994


   test it - ignore it


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA2 commented on pull request #4058:
URL: https://github.com/apache/carbondata/pull/4058#issuecomment-748049570


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5208/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA2 commented on pull request #4058:
URL: https://github.com/apache/carbondata/pull/4058#issuecomment-748051716


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3448/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

ajantha-bhat commented on pull request #4058:
URL: https://github.com/apache/carbondata/pull/4058#issuecomment-748061201


   LGTM.
   
   
   As the actual value is already LV, putBytes() no need to append L again, but that change is more, as many classes need to modified.
   Current change of removing L from actual value and appending L again is fine as it is (corner) fallback scenario.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

asfgit closed pull request #4058:
URL: https://github.com/apache/carbondata/pull/4058


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]