[GitHub] [carbondata] kunal642 commented on a change in pull request #3138: [CARBONDATA-3305] Added DDL to drop cache for a table

[GitBox]

kunal642 commented on a change in pull request #3138: [CARBONDATA-3305] Added DDL to drop cache for a table
URL: https://github.com/apache/carbondata/pull/3138#discussion_r262790768
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/cache/CarbonLRUCache.java
 ##########
 @@ -62,10 +62,10 @@
    */
   public CarbonLRUCache(String propertyName, String defaultPropertyName) {
     try {
-      lruCacheMemorySize = Integer
-          .parseInt(CarbonProperties.getInstance().getProperty(propertyName, defaultPropertyName));
+      lruCacheMemorySize = Long
+          .parseLong(CarbonProperties.getInstance().getProperty(propertyName, defaultPropertyName));
     } catch (NumberFormatException e) {
-      lruCacheMemorySize = Integer.parseInt(defaultPropertyName);
+      lruCacheMemorySize = Long.parseLong(defaultPropertyName);
 
 Review comment:
   Add a log specifying that the configured LRU size is not a valid format therefore taking the default value(mention the default value as well)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services