[GitHub] [carbondata] kunal642 commented on a change in pull request #3174: [CARBONDATA-3344] Fix Drop column not present in table

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] kunal642 commented on a change in pull request #3174: [CARBONDATA-3344] Fix Drop column not present in table

GitBox
kunal642 commented on a change in pull request #3174: [CARBONDATA-3344] Fix Drop column not present in table
URL: https://github.com/apache/carbondata/pull/3174#discussion_r273323977
 
 

 ##########
 File path: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableDropColumnCommand.scala
 ##########
 @@ -108,6 +99,15 @@ private[sql] case class CarbonAlterTableDropColumnCommand(
         }
       }
 
+      // Check if column to be dropped is of complex dataType
+      alterTableDropColumnModel.columns.foreach { column =>
+        if (carbonTable.getColumnByName(alterTableDropColumnModel.tableName, column).getDataType
 
 Review comment:
   Can we merge this loop and the loop on line 83

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services