[GitHub] [carbondata] kunal642 commented on a change in pull request #3208: [CARBONDATA-3378]Display original query in Indexserver Job

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] kunal642 commented on a change in pull request #3208: [CARBONDATA-3378]Display original query in Indexserver Job

GitBox
kunal642 commented on a change in pull request #3208: [CARBONDATA-3378]Display original query in Indexserver Job
URL: https://github.com/apache/carbondata/pull/3208#discussion_r285857330
 
 

 ##########
 File path: integration/spark2/src/main/scala/org/apache/carbondata/indexserver/IndexServer.scala
 ##########
 @@ -42,7 +42,8 @@ trait ServerInterface {
   /**
    * Used to prune and cache the datamaps for the table.
    */
-  def getSplits(request: DistributableDataMapFormat): Array[ExtendedBlocklet]
+  def getSplits(request: DistributableDataMapFormat, taskGroupId: String, taskGroupDesc: String):
 
 Review comment:
   Its better to add task group id and taskGroupDesc in a wrapper othewise the query would be displayed in the index server driver logs which may cause security breach

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services