[GitHub] [carbondata] kunal642 commented on a change in pull request #3308: [WIP] [CARBONDATA-3454] optimized index server output for count(*)

[GitBox]

kunal642 commented on a change in pull request #3308: [WIP] [CARBONDATA-3454] optimized index server output for count(*)
URL: https://github.com/apache/carbondata/pull/3308#discussion_r298097026
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/indexstore/ExtendedBlocklet.java
 ##########
 @@ -161,30 +176,35 @@ public void setColumnSchema(List<ColumnSchema> columnSchema) {
    * @param uniqueLocation
    * @throws IOException
    */
-  public void serializeData(DataOutput out, Map<String, Short> uniqueLocation)
+  public void serializeData(DataOutput out, Map<String, Short> uniqueLocation, boolean isCountJob)
       throws IOException {
     super.write(out);
-    if (dataMapUniqueId == null) {
-      out.writeBoolean(false);
+    if (isCountJob) {
 
 Review comment:
   this is a if else block, return is not required. i have added return to the read method instead.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services