[GitHub] [carbondata] kunal642 commented on a change in pull request #3339: [CARBONDATA-3480] Fixed unnecessary refresh for table by removing modified mdt file

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] kunal642 commented on a change in pull request #3339: [CARBONDATA-3480] Fixed unnecessary refresh for table by removing modified mdt file

GitBox
kunal642 commented on a change in pull request #3339: [CARBONDATA-3480] Fixed unnecessary refresh for table by removing modified mdt file
URL: https://github.com/apache/carbondata/pull/3339#discussion_r309525330
 
 

 ##########
 File path: integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonFileMetastore.scala
 ##########
 @@ -417,59 +396,30 @@ class CarbonFileMetastore extends CarbonMetaStore {
     thriftWriter.open(FileWriteOperation.OVERWRITE)
     thriftWriter.write(thriftTableInfo)
     thriftWriter.close()
-    updateSchemasUpdatedTime(touchSchemaFileSystemTime())
+    updateSchemasUpdatedTime(thriftTableInfo.getFact_table.getTable_id, thriftTableInfo
+      .getFact_table.getSchema_evolution.schema_evolution_history.get(0).time_stamp)
 
 Review comment:
   We dont actually need the file timestamp...schema evolution entry can also do the job because evertime the schema file is written a new entry for evolution is added to the schema.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services