[GitHub] [carbondata] kunal642 commented on a change in pull request #3354: [CARBONDATA-3489] Optimized the comparator instances in sort

[GitBox]

kunal642 commented on a change in pull request #3354: [CARBONDATA-3489] Optimized the comparator instances in sort
URL: https://github.com/apache/carbondata/pull/3354#discussion_r318892551
 
 

 ##########
 File path: processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/IntermediateSortTempRowComparator.java
 ##########
 @@ -36,13 +38,35 @@
 
   private DataType[] noDicSortDataTypes;
 
+  private Map<DataType, SerializableComparator> comparator_map;
+
   /**
    * @param isSortColumnNoDictionary isSortColumnNoDictionary
    */
   public IntermediateSortTempRowComparator(boolean[] isSortColumnNoDictionary,
       DataType[] noDicSortDataTypes) {
     this.isSortColumnNoDictionary = isSortColumnNoDictionary;
     this.noDicSortDataTypes = noDicSortDataTypes;
+    comparator_map = new HashMap<>();
 
 Review comment:
   Now this code is not required..Please remove
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services