[GitHub] [carbondata] kunal642 commented on a change in pull request #3374: [CARBONDATA-3496] Maintain the list of TableDataMap based on tableId instead of tableName

[GitBox]

kunal642 commented on a change in pull request #3374: [CARBONDATA-3496] Maintain the list of TableDataMap based on tableId instead of tableName
URL: https://github.com/apache/carbondata/pull/3374#discussion_r334461323
 
 

 ##########
 File path: integration/spark-common/src/main/scala/org/apache/spark/sql/hive/DistributionUtil.scala
 ##########
 @@ -89,7 +89,16 @@ object DistributionUtil {
     }
   }
 
-  def getExecutors(sparkContext: SparkContext): Map[String, Seq[String]] = {
+  def assignAndGetExecutors(sparkContext: SparkContext): Map[String, Seq[String]] = {
+    val availableExecutors = getExecutors(sparkContext)
+    if (availableExecutors.isEmpty) {
+      val configuredExecutorInstances = sparkContext.getConf.getInt("spark.executor.instances", 0)
+      sparkContext.requestExecutors(configuredExecutorInstances)
 
 Review comment:
   Actually ill remove this code..after analysis there are some scenarios that are not possible to handle with dynamicAllocation = true. So instead of this we will not start index server if dynamicAllocation is true.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services