[GitHub] [carbondata] kunal642 commented on a change in pull request #3416: [HOTFIX][TESTCASE] Testcase fix for replacing lambda function for Java-1.7

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] kunal642 commented on a change in pull request #3416: [HOTFIX][TESTCASE] Testcase fix for replacing lambda function for Java-1.7

GitBox
kunal642 commented on a change in pull request #3416: [HOTFIX][TESTCASE] Testcase fix for replacing lambda function for Java-1.7
URL: https://github.com/apache/carbondata/pull/3416#discussion_r337887172
 
 

 ##########
 File path: tools/cli/src/test/java/org/apache/carbondata/tool/CarbonCliTest.java
 ##########
 @@ -275,9 +277,14 @@ public void testSummaryAllColumns() {
   @Test
   public void testSummaryAllColumnsForOneFile() {
     CarbonFile folder = FileFactory.getCarbonFile(path);
-    CarbonFile[] carbonFiles =
-        folder.listFiles(file -> file.getName().endsWith(CarbonTablePath.CARBON_DATA_EXT));
-    String[] args = { "-cmd", "summary", "-p", carbonFiles[0].getCanonicalPath(), "-C" };
+    CarbonFile[] allFiles = folder.listFiles();
 
 Review comment:
   I asked manish to pass a carbonfilter to the list files interface instead of looping and filtering

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services