[GitHub] [carbondata] kunal642 commented on a change in pull request #3700: [WIP] Added spark binary version to related modules

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] kunal642 commented on a change in pull request #3700: [WIP] Added spark binary version to related modules

GitBox

kunal642 commented on a change in pull request #3700:
URL: https://github.com/apache/carbondata/pull/3700#discussion_r415230420



##########
File path: pom.xml
##########
@@ -124,6 +124,7 @@
     <!--    default properties-->
     <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
     <snappy.version>1.1.2.6</snappy.version>
+    <spark.binary.version>2.3</spark.binary.version>

Review comment:
       No, because default profile is 2.3,  i have removed the global property and let the profiles decide the version




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]