[GitHub] [carbondata] kunal642 opened a new pull request #3636: [CARBONDATA-3719] upgraded hive version to 3.1.0

[GitBox]

kunal642 opened a new pull request #3636: [CARBONDATA-3719] upgraded hive version to 3.1.0
URL: https://github.com/apache/carbondata/pull/3636
 
 
    ### Why is this PR needed?
   
   
    ### What changes were proposed in this PR?
   
       
    ### Does this PR introduce any user interface change?
    - No
    - Yes. (please explain the change and update document)
   
    ### Is any new testcase added?
    - No
    - Yes
   
       
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3636: [CARBONDATA-3719] upgraded hive version to 3.1.0
URL: https://github.com/apache/carbondata/pull/3636#issuecomment-590046627
 
 
   Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/407/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3636: [CARBONDATA-3719] upgraded hive version to 3.1.0
URL: https://github.com/apache/carbondata/pull/3636#issuecomment-590046834
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2108/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3636: [CARBONDATA-3719] upgraded hive version to 3.1.0
URL: https://github.com/apache/carbondata/pull/3636#issuecomment-590100377
 
 
   Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/411/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3636: [CARBONDATA-3719] upgraded hive version to 3.1.0
URL: https://github.com/apache/carbondata/pull/3636#issuecomment-590100708
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2112/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

ajantha-bhat commented on a change in pull request #3636: [CARBONDATA-3719] upgraded hive version to 3.1.0
URL: https://github.com/apache/carbondata/pull/3636#discussion_r383083536
 
 

 ##########
 File path: examples/spark2/src/main/scala/org/apache/carbondata/examples/HiveExample.scala
 ##########
 @@ -1,303 +0,0 @@
-/*
 
 Review comment:
   why removed this example ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

ajantha-bhat commented on a change in pull request #3636: [CARBONDATA-3719] upgraded hive version to 3.1.0
URL: https://github.com/apache/carbondata/pull/3636#discussion_r383083637
 
 

 ##########
 File path: examples/spark2/pom.xml
 ##########
 @@ -34,11 +34,6 @@
   </properties>
 
   <dependencies>
-    <dependency>
-      <groupId>org.apache.carbondata</groupId>
-      <artifactId>carbondata-hive</artifactId>
 
 Review comment:
   This added for that example ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

ajantha-bhat commented on a change in pull request #3636: [CARBONDATA-3719] upgraded hive version to 3.1.0
URL: https://github.com/apache/carbondata/pull/3636#discussion_r383084097
 
 

 ##########
 File path: integration/spark-common/src/main/scala/org/apache/spark/util/CarbonReflectionUtils.scala
 ##########
 @@ -232,38 +230,6 @@ object CarbonReflectionUtils {
     (ctor.newInstance(conArgs: _*), clazz)
   }
 
-  /**
-   * It is a hack to update the carbon input, output format information to #HiveSerDe
-   */
-  def updateCarbonSerdeInfo(): Unit = {
-    val currentMirror = scala.reflect.runtime.currentMirror
 
 Review comment:
   I think this was done for presto scenario. Spark writes a carbon table to hive metastore. That time serde was not updated. so the read from presto was failing. It may not work now. Can check in cluster

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3636: [CARBONDATA-3719] upgraded hive version to 3.1.0
URL: https://github.com/apache/carbondata/pull/3636#issuecomment-592417019
 
 
   Build Failed  with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/518/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3636: [CARBONDATA-3719] upgraded hive version to 3.1.0
URL: https://github.com/apache/carbondata/pull/3636#issuecomment-592424163
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2218/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3636: [CARBONDATA-3719] upgraded hive version to 3.1.0
URL: https://github.com/apache/carbondata/pull/3636#issuecomment-592431655
 
 
   Build Failed  with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/523/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3636: [CARBONDATA-3719] upgraded hive version to 3.1.0
URL: https://github.com/apache/carbondata/pull/3636#issuecomment-592463272
 
 
   Build Failed  with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/527/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3636: [CARBONDATA-3719] upgraded hive version to 3.1.0
URL: https://github.com/apache/carbondata/pull/3636#issuecomment-592470536
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2227/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3636: [CARBONDATA-3719] upgraded hive version to 3.1.0
URL: https://github.com/apache/carbondata/pull/3636#issuecomment-592495686
 
 
   Build Failed  with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/531/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3636: [CARBONDATA-3719] upgraded hive version to 3.1.0
URL: https://github.com/apache/carbondata/pull/3636#issuecomment-592502237
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2231/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3636: [CARBONDATA-3719] upgraded hive version to 3.1.0
URL: https://github.com/apache/carbondata/pull/3636#issuecomment-593123944
 
 
   Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/549/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3636: [CARBONDATA-3719] upgraded hive version to 3.1.0
URL: https://github.com/apache/carbondata/pull/3636#issuecomment-593132647
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2249/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3636: [CARBONDATA-3719] upgraded hive version to 3.1.0
URL: https://github.com/apache/carbondata/pull/3636#issuecomment-593239523
 
 
   Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/555/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3636: [CARBONDATA-3719] upgraded hive version to 3.1.0
URL: https://github.com/apache/carbondata/pull/3636#issuecomment-593261892
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2255/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

jackylk commented on issue #3636: [CARBONDATA-3719] upgraded hive version to 3.1.0
URL: https://github.com/apache/carbondata/pull/3636#issuecomment-593290215
 
 
   LGTM

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services