[GitHub] [carbondata] kunal642 opened a new pull request #3738: [HOTFIX ] Fix documentation for various features

classic Classic list List threaded Threaded
24 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] kunal642 commented on a change in pull request #3738: [CARBONDATA-3791] Fix documentation for various features

GitBox

kunal642 commented on a change in pull request #3738:
URL: https://github.com/apache/carbondata/pull/3738#discussion_r420773716



##########
File path: docs/ddl-of-carbondata.md
##########
@@ -608,12 +607,10 @@ CarbonData DDL statements are documented here,which includes:
   This can be SDK output or C++ SDK output. Refer [SDK Guide](./sdk-guide.md) and [C++ SDK Guide](./csdk-guide.md).
 
   **Note:**
-  1. Dropping of the external table should not delete the files present in the location.
+  1. Dropping of the external table will not delete the files present in the location.
   2. When external table is created on non-transactional table data,
     external table will be registered with the schema of carbondata files.
-    If multiple files with different schema is present, exception will be thrown.
-    So, If table registered with one schema and files are of different schema,
-    suggest to drop the external table and create again to register table with new schema.  
+    If multiple files with different schema is present, exception will be thrown.  

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3738: [CARBONDATA-3791] Fix documentation for various features

GitBox
In reply to this post by GitBox

CarbonDataQA1 commented on pull request #3738:
URL: https://github.com/apache/carbondata/pull/3738#issuecomment-624715918


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2958/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3738: [CARBONDATA-3791] Fix documentation for various features

GitBox
In reply to this post by GitBox

CarbonDataQA1 commented on pull request #3738:
URL: https://github.com/apache/carbondata/pull/3738#issuecomment-624716268


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1240/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] akashrn5 commented on pull request #3738: [CARBONDATA-3791] Fix documentation for various features

GitBox
In reply to this post by GitBox

akashrn5 commented on pull request #3738:
URL: https://github.com/apache/carbondata/pull/3738#issuecomment-624733114


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


12