[GitHub] [carbondata] kunal642 opened a new pull request #3783: [CARBONDATA-3840] Mark features as experimental

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] kunal642 opened a new pull request #3783: [CARBONDATA-3840] Mark features as experimental

GitBox

kunal642 opened a new pull request #3783:
URL: https://github.com/apache/carbondata/pull/3783


    ### Why is this PR needed?
    Mark features as experimental because they are subject to change in future.
   
    ### What changes were proposed in this PR?
    Mark features as experimental because they are subject to change in future.
       
    ### Does this PR introduce any user interface change?
    - No
   
    ### Is any new testcase added?
    - No
   
   
       
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] jackylk commented on a change in pull request #3783: [CARBONDATA-3840] Mark features as experimental

GitBox

jackylk commented on a change in pull request #3783:
URL: https://github.com/apache/carbondata/pull/3783#discussion_r433095610



##########
File path: README.md
##########
@@ -69,6 +69,14 @@ CarbonData is built using Apache Maven, to [build CarbonData](https://github.com
 * [Carbon as Spark's Datasource](https://github.com/apache/carbondata/blob/master/docs/carbon-as-spark-datasource-guide.md)
 * [FAQs](https://github.com/apache/carbondata/blob/master/docs/faq.md)
 
+## Experimental Features
+
+Some features are marked as experimental because the syntax/implementation might change in the future.
+1. Hybrid format table using Add Segment.
+2. Accelerating performance using MV on parquet/orc.
+3. CDC and SCD.

Review comment:
       mention only for MERGE API for Spark DataFrame
   UPDATE and DELETE is production feature




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] jackylk commented on a change in pull request #3783: [CARBONDATA-3840] Mark features as experimental

GitBox
In reply to this post by GitBox

jackylk commented on a change in pull request #3783:
URL: https://github.com/apache/carbondata/pull/3783#discussion_r433095610



##########
File path: README.md
##########
@@ -69,6 +69,14 @@ CarbonData is built using Apache Maven, to [build CarbonData](https://github.com
 * [Carbon as Spark's Datasource](https://github.com/apache/carbondata/blob/master/docs/carbon-as-spark-datasource-guide.md)
 * [FAQs](https://github.com/apache/carbondata/blob/master/docs/faq.md)
 
+## Experimental Features
+
+Some features are marked as experimental because the syntax/implementation might change in the future.
+1. Hybrid format table using Add Segment.
+2. Accelerating performance using MV on parquet/orc.
+3. CDC and SCD.

Review comment:
       mention only for MERGE API for Spark DataFrame
   UPDATE and DELETE is production feature, and no need to mention CDC and SCD




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] kunal642 commented on a change in pull request #3783: [CARBONDATA-3840] Mark features as experimental

GitBox
In reply to this post by GitBox

kunal642 commented on a change in pull request #3783:
URL: https://github.com/apache/carbondata/pull/3783#discussion_r433098465



##########
File path: README.md
##########
@@ -69,6 +69,14 @@ CarbonData is built using Apache Maven, to [build CarbonData](https://github.com
 * [Carbon as Spark's Datasource](https://github.com/apache/carbondata/blob/master/docs/carbon-as-spark-datasource-guide.md)
 * [FAQs](https://github.com/apache/carbondata/blob/master/docs/faq.md)
 
+## Experimental Features
+
+Some features are marked as experimental because the syntax/implementation might change in the future.
+1. Hybrid format table using Add Segment.
+2. Accelerating performance using MV on parquet/orc.
+3. CDC and SCD.

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] jackylk commented on pull request #3783: [CARBONDATA-3840] Mark features as experimental

GitBox
In reply to this post by GitBox

jackylk commented on pull request #3783:
URL: https://github.com/apache/carbondata/pull/3783#issuecomment-636695185


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] asfgit closed pull request #3783: [CARBONDATA-3840] Mark features as experimental

GitBox
In reply to this post by GitBox

asfgit closed pull request #3783:
URL: https://github.com/apache/carbondata/pull/3783


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3783: [CARBONDATA-3840] Mark features as experimental

GitBox
In reply to this post by GitBox

CarbonDataQA1 commented on pull request #3783:
URL: https://github.com/apache/carbondata/pull/3783#issuecomment-636766357


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3117/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3783: [CARBONDATA-3840] Mark features as experimental

GitBox
In reply to this post by GitBox

CarbonDataQA1 commented on pull request #3783:
URL: https://github.com/apache/carbondata/pull/3783#issuecomment-636766737


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1393/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]