[GitHub] [carbondata] lamber-ken commented on a change in pull request #3230: [HOTFIX] fix error table location path in HadoopFileExample

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] lamber-ken commented on a change in pull request #3230: [HOTFIX] fix error table location path in HadoopFileExample

GitBox
lamber-ken commented on a change in pull request #3230: [HOTFIX] fix error table location path in HadoopFileExample
URL: https://github.com/apache/carbondata/pull/3230#discussion_r287558872
 
 

 ##########
 File path: examples/spark2/src/main/scala/org/apache/carbondata/examples/HadoopFileExample.scala
 ##########
 @@ -61,7 +61,7 @@ object HadoopFileExample {
     CarbonInputFormat.setTableName(conf, "Hadoopfile_table")
 
 
-    val input = spark.sparkContext.newAPIHadoopFile(s"${storeLocation}/Hadoopfile_table",
+    val input = spark.sparkContext.newAPIHadoopFile(s"${storeLocation}/hadoopfile_table",
 
 Review comment:
   > why you modify only one,this file has serveral `Hadoopfile_table`?
   
   I think it's no need to change other `Hadoopfile_table`. When use spark dataframe to save table, it'll use lower case table name as the location, so this pr fix the bug.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services