[GitHub] [carbondata] liuhe0702 opened a new pull request #4102: [CARBONDATA-4144] After the alter table xxx compact command is executed, the index size of the segment is 0, and an error is rep…orted while quering

classic Classic list List threaded Threaded
26 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] liuhe0702 commented on a change in pull request #4102: [CARBONDATA-4144] During compaction, the segment lock of SI table is not released in abnormal scenarios.

GitBox

liuhe0702 commented on a change in pull request #4102:
URL: https://github.com/apache/carbondata/pull/4102#discussion_r596893792



##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/load/Compactor.scala
##########
@@ -93,6 +93,9 @@ object Compactor {
             segmentToSegmentTimestampMap, null,
             forceAccessSegment, isCompactionCall = true,
             isLoadToFailedSISegments = false)
+        if (segmentLocks.isEmpty) {

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] akashrn5 commented on pull request #4102: [CARBONDATA-4144] During compaction, the segment lock of SI table is not released in abnormal scenarios.

GitBox
In reply to this post by GitBox

akashrn5 commented on pull request #4102:
URL: https://github.com/apache/carbondata/pull/4102#issuecomment-801950416


   LGTM, can be merged once build passes


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4102: [CARBONDATA-4144] During compaction, the segment lock of SI table is not released in abnormal scenarios.

GitBox
In reply to this post by GitBox

CarbonDataQA2 commented on pull request #4102:
URL: https://github.com/apache/carbondata/pull/4102#issuecomment-802070582


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5587/
   


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4102: [CARBONDATA-4144] During compaction, the segment lock of SI table is not released in abnormal scenarios.

GitBox
In reply to this post by GitBox

CarbonDataQA2 commented on pull request #4102:
URL: https://github.com/apache/carbondata/pull/4102#issuecomment-802099779


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3821/
   


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] asfgit closed pull request #4102: [CARBONDATA-4144] During compaction, the segment lock of SI table is not released in abnormal scenarios.

GitBox
In reply to this post by GitBox

asfgit closed pull request #4102:
URL: https://github.com/apache/carbondata/pull/4102


   


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] akashrn5 commented on pull request #4102: [CARBONDATA-4144] During compaction, the segment lock of SI table is not released in abnormal scenarios.

GitBox
In reply to this post by GitBox

akashrn5 commented on pull request #4102:
URL: https://github.com/apache/carbondata/pull/4102#issuecomment-802727517


   #3988 PR takes time to stabilize, so merging this to avoid issue.
   


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


12