[GitHub] [carbondata] maheshrajus opened a new pull request #3957: [WIP] drop index table is failed with table not found exception

[GitBox]

maheshrajus opened a new pull request #3957:
URL: https://github.com/apache/carbondata/pull/3957


    ### Why is this PR needed?
    drop index table is failed with table not found exception
   
    ### What changes were proposed in this PR?
   
       
    ### Does this PR introduce any user interface change?
    - No
    - Yes. (please explain the change and update document)
   
    ### Is any new testcase added?
    - No
    - Yes
   
       
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

Indhumathi27 commented on a change in pull request #3957:
URL: https://github.com/apache/carbondata/pull/3957#discussion_r494856214



##########
File path: index/secondary-index/src/test/scala/org/apache/carbondata/spark/testsuite/secondaryindex/DropTableTest.scala
##########
@@ -74,4 +74,17 @@ class DropTableTest extends QueryTest with BeforeAndAfterAll {
     assert(exception.getMessage.contains("Index with name indtestdrop does not exist"))
     sql("drop table if exists testDrop")
   }
+
+  test("test drop index command after refresh the index for empty index table") {
+    sql("drop table if exists testDropIndex")
+    sql("create table testDropIndex (a string, b string, c string) STORED AS carbondata")
+    sql("create index helloIndex on table testDropIndex (c) AS 'carbondata' properties" +
+        "('table_blocksize'='1')")
+    sql("show indexes on testDropIndex").show()

Review comment:
       please remove this line




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3957:
URL: https://github.com/apache/carbondata/pull/3957#issuecomment-698821503


   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4210/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3957:
URL: https://github.com/apache/carbondata/pull/3957#issuecomment-698825430


   Build Failed  with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2467/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3957:
URL: https://github.com/apache/carbondata/pull/3957#issuecomment-698900072


   Build Failed  with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2473/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3957:
URL: https://github.com/apache/carbondata/pull/3957#issuecomment-698901000


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4216/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

Indhumathi27 commented on a change in pull request #3957:
URL: https://github.com/apache/carbondata/pull/3957#discussion_r494856214



##########
File path: index/secondary-index/src/test/scala/org/apache/carbondata/spark/testsuite/secondaryindex/DropTableTest.scala
##########
@@ -74,4 +74,17 @@ class DropTableTest extends QueryTest with BeforeAndAfterAll {
     assert(exception.getMessage.contains("Index with name indtestdrop does not exist"))
     sql("drop table if exists testDrop")
   }
+
+  test("test drop index command after refresh the index for empty index table") {
+    sql("drop table if exists testDropIndex")
+    sql("create table testDropIndex (a string, b string, c string) STORED AS carbondata")
+    sql("create index helloIndex on table testDropIndex (c) AS 'carbondata' properties" +
+        "('table_blocksize'='1')")
+    sql("show indexes on testDropIndex").show()

Review comment:
       please remove this line




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3957:
URL: https://github.com/apache/carbondata/pull/3957#issuecomment-698821503






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

maheshrajus commented on pull request #3957:
URL: https://github.com/apache/carbondata/pull/3957#issuecomment-699034567


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3957:
URL: https://github.com/apache/carbondata/pull/3957#issuecomment-699092326


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4224/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3957:
URL: https://github.com/apache/carbondata/pull/3957#issuecomment-699092913


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2480/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

ajantha-bhat commented on pull request #3957:
URL: https://github.com/apache/carbondata/pull/3957#issuecomment-699985962


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

asfgit closed pull request #3957:
URL: https://github.com/apache/carbondata/pull/3957


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]