[GitHub] [carbondata] manishgupta88 commented on a change in pull request #3148: [CARBONDATA-3293] Prune datamaps improvement for count(*)

[GitBox]

manishgupta88 commented on a change in pull request #3148: [CARBONDATA-3293] Prune datamaps improvement for count(*)
URL: https://github.com/apache/carbondata/pull/3148#discussion_r266526739
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/indexstore/UnsafeMemoryDMStore.java
 ##########
 @@ -48,6 +48,8 @@
 
   private int rowCount;
 
+  private long totalRowCount;
 
 Review comment:
   I agree with @ravipesala ...you can keep it in unsafe

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services