[GitHub] [carbondata] manishgupta88 commented on a change in pull request #3148: [CARBONDATA-3293] Prune datamaps improvement for count(*)

[GitBox]

manishgupta88 commented on a change in pull request #3148: [CARBONDATA-3293] Prune datamaps improvement for count(*)
URL: https://github.com/apache/carbondata/pull/3148#discussion_r266528493
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockDataMap.java
 ##########
 @@ -648,6 +652,51 @@ protected int getTotalBlocklets() {
     return sum;
   }
 
+  @Override public Map<String, Long> getRowCount(Segment segment, List<PartitionSpec> partitions,
+      Map<String, Long> blockletToRowCountMap) throws IOException {
+    if (taskSummaryDMStore.getTotalRowCount() == 0) {
+      return getRowCountForEachBlock(segment, partitions, blockletToRowCountMap);
+    } else {
+      if (taskSummaryDMStore.getRowCount() == 0) {
+        return new HashMap<>();
+      }
+      Long rowCount = blockletToRowCountMap.get("RowCount");
+      long totalRowCount = taskSummaryDMStore.getTotalRowCount();
+      if (null == rowCount) {
+        blockletToRowCountMap.put("RowCount", totalRowCount);
+      } else {
+        blockletToRowCountMap.put("RowCount", totalRowCount + rowCount);
 
 Review comment:
   you key is always static `RowCount`. Any particular reason to use HashMap here? Can return type be changed to return the long value?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services