[GitHub] [carbondata] manishgupta88 commented on a change in pull request #3148: [CARBONDATA-3293] Prune datamaps improvement for count(*)

[GitBox]

manishgupta88 commented on a change in pull request #3148: [CARBONDATA-3293] Prune datamaps improvement for count(*)
URL: https://github.com/apache/carbondata/pull/3148#discussion_r266524648
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/indexstore/AbstractMemoryDMStore.java
 ##########
 @@ -52,4 +52,13 @@ public UnsafeMemoryDMStore convertToUnsafeDMStore(CarbonRowSchema[] schema)
       throws MemoryException {
     throw new UnsupportedOperationException("Operation not allowed");
   }
+
+  public void setTotalRowCount(long rowCount) {
 
 Review comment:
   Setter methods should not be overridden. You can make rowCount protected in abstract class and avoid overriding the setter method

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services