manishgupta88 commented on a change in pull request #3177: [CARBONDATA-3337][CARBONDATA-3306] Distributed index server
URL:
https://github.com/apache/carbondata/pull/3177#discussion_r277665566
##########
File path: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
##########
@@ -2104,4 +2104,34 @@ private CarbonCommonConstants() {
*/
public static final String CARBON_QUERY_DATAMAP_BLOOM_CACHE_SIZE_DEFAULT_VAL = "512";
+ /**
+ * The IP on which Index Server will be started.
+ */
+ @CarbonProperty
+ public static final String CARBON_INDEX_SERVER_IP = "carbon.index.server.ip";
Review comment:
`CarbonCommonConstants.java` file has too many constants defined. Can we think of seggregating the properties based on their usage. Like all properties defined for index cache server can be moved to a separate constants file (e.g CacheIndexServerConstants) OR we can also think of introducing builder pattern to construct properties with default/specified values
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]
With regards,
Apache Git Services
Locked
