[GitHub] [carbondata] manishgupta88 commented on a change in pull request #3177: [CARBONDATA-3337][CARBONDATA-3306] Distributed index server

[GitBox]

manishgupta88 commented on a change in pull request #3177: [CARBONDATA-3337][CARBONDATA-3306] Distributed index server
URL: https://github.com/apache/carbondata/pull/3177#discussion_r278192432
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java
 ##########
 @@ -1385,4 +1387,14 @@ public static boolean hasMVDataMap(CarbonTable carbonTable) throws IOException {
       return SortScopeOptions.getSortScope(sortScope);
     }
   }
+
+  @Override public void write(DataOutput out) throws IOException {
+    tableInfo.write(out);
+  }
+
+  @Override public void readFields(DataInput in) throws IOException {
 
 Review comment:
   @xuchuanyin ...`in` and `out` here are `DataInputStream` and `DataOutputStream` and I think it is ok to use `in` and `out` as these are common reference names used for input and output stream unless its very specific

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services