[GitHub] [carbondata] manishgupta88 commented on a change in pull request #3281: [WIP]Index server performance improvement

[GitBox]

manishgupta88 commented on a change in pull request #3281: [WIP]Index server performance improvement
URL: https://github.com/apache/carbondata/pull/3281#discussion_r293672588
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
 ##########
 @@ -2189,9 +2197,42 @@ private CarbonCommonConstants() {
 
   public static final String LOAD_SYNC_TIME = "load_sync_time";
 
-  public  static final String CARBON_INDEX_SERVER_JOBNAME_LENGTH =
+  public static final String CARBON_INDEX_SERVER_JOBNAME_LENGTH =
           "carbon.index.server.max.jobname.length";
 
-  public  static final String CARBON_INDEX_SERVER_JOBNAME_LENGTH_DEFAULT =
+  public static final String CARBON_INDEX_SERVER_JOBNAME_LENGTH_DEFAULT =
           "50";
+
+  @CarbonProperty
+  /**
+   * Max in memory serialization size after reaching threshold data will
+   * be written to file
+   */
+  public static final String CARBON_INDEX_SERVER_SERIALIZATION_THRESHOLD =
+      "carbon.index.server.inmemory.serialization.threshold.inKB";
+
+  /**
+   * default value for in memory serialization size
+   */
+  public static final String CARBON_INDEX_SERVER_SERIALIZATION_THRESHOLD_DEFAULT = "300";
+
+  /**
+   * min value for in memory serialization size
+   */
+  public static final int CARBON_INDEX_SERVER_SERIALIZATION_THRESHOLD_MIN = 100;
+
+  /**
+   * max value for in memory serialization size
+   */
+  public static final int CARBON_INDEX_SERVER_SERIALIZATION_THRESHOLD_MAX = 102400;
+
+  /**
+   * will be used to write split serialize data when in memory threashold crosses the limit
+   */
+  public static final String CARBON_INDEX_SERVER_TEMP_PATH = "carbon.indexserver.temp.path";
+
+  /**
+   * index server temp file name
+   */
+  public static final String INDEX_SERVER_TEMP_FOLDER_NAME = "indexservertmp";
 
 Review comment:
   I think `CarbonCommonConstants` file already has around 2k lines. Its better to move all the properties related to index server to a new constant file `IndexServerConstants`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services