[GitHub] [carbondata] manishnalla1994 commented on a change in pull request #3182: [CARBONDATA-3343] Compaction for Range Sort

[GitBox]

manishnalla1994 commented on a change in pull request #3182: [CARBONDATA-3343] Compaction for Range Sort
URL: https://github.com/apache/carbondata/pull/3182#discussion_r277979059
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/scan/result/BlockletScannedResult.java
 ##########
 @@ -530,6 +530,20 @@ protected void fillValidRowIdsBatchFilling(int rowId, int batchSize) {
     }
   }
 
+  protected void fillValidRowIdsBatchFillingWithFilter(int rowId, int batchSize) {
+    // row id will be different for every batch so clear it before filling
+    clearValidRowIdList();
+    int startPosition = rowId;
+    for (int i = 0, j = startPosition;
+         i < batchSize && j < pageFilteredRowId[pageCounter].length; i++) {
 
 Review comment:
   Yes I tested and the caller handles it so removed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services