[GitHub] [carbondata] manishnalla1994 commented on a change in pull request #3288: [CARBONDATA-3437] Changed implementation of Map datatype

[GitBox]

manishnalla1994 commented on a change in pull request #3288: [CARBONDATA-3437] Changed implementation of Map datatype
URL: https://github.com/apache/carbondata/pull/3288#discussion_r296594305
 
 

 ##########
 File path: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/createTable/TestCreateDDLForComplexMapType.scala
 ##########
 @@ -482,8 +482,8 @@ class TestCreateDDLForComplexMapType extends QueryTest with BeforeAndAfterAll {
        """.stripMargin)
     sql("INSERT INTO carbon SELECT * FROM carbon")
     checkAnswer(sql("select * from carbon"), Seq(
-      Row(Map(1 -> "Nalla", 2 -> "Singh", 4 -> "Kumar")),
-      Row(Map(1 -> "Nalla", 2 -> "Singh", 4 -> "Kumar")),
+      Row(Map(1 -> "Gupta", 2 -> "Singh", 4 -> "Kumar")),
+      Row(Map(1 -> "Gupta", 2 -> "Singh", 4 -> "Kumar")),
 
 Review comment:
   Actually the earlier testcases were based on Map having the older values, now the implementation is being changed to override the older values in the map with the new values that come after.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services