[GitHub] [carbondata] manishnalla1994 commented on a change in pull request #3426: [CARBONDATA-3560] Fixed issues for Add Segment

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] manishnalla1994 commented on a change in pull request #3426: [CARBONDATA-3560] Fixed issues for Add Segment

GitBox
manishnalla1994 commented on a change in pull request #3426: [CARBONDATA-3560] Fixed issues for Add Segment
URL: https://github.com/apache/carbondata/pull/3426#discussion_r341902473
 
 

 ##########
 File path: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonAddLoadCommand.scala
 ##########
 @@ -92,6 +92,22 @@ case class CarbonAddLoadCommand(
     val segmentPath = options.getOrElse(
       "path", throw new UnsupportedOperationException("PATH is manadatory"))
 
+    val format = options.getOrElse("format", "carbondata")
+    val isCarbonFormat = format.equals("carbondata") || format.equals("carbon")
+
+    val allSegments = SegmentStatusManager.readLoadMetadata(carbonTable.getMetadataPath)
+
+    for (currSegment <- allSegments) {
+      if (currSegment.getPath != null && currSegment.getPath.equalsIgnoreCase(segmentPath)) {
+        throw new AnalysisException(s"Cannot add the segment. This path is already in use by " +
+                                    s"another segment.")
+      }
+    }
+
+    if (isCarbonFormat && SegmentFileStore.getListOfCarbonIndexFiles(segmentPath).isEmpty) {
 
 Review comment:
   Done.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services