[GitHub] [carbondata] manishnalla1994 commented on a change in pull request #3457: [HOTFIX] Ignore testcase for compatibility problem in spark 2.1

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] manishnalla1994 commented on a change in pull request #3457: [HOTFIX] Ignore testcase for compatibility problem in spark 2.1

GitBox
manishnalla1994 commented on a change in pull request #3457: [HOTFIX] Ignore testcase for compatibility problem in spark 2.1
URL: https://github.com/apache/carbondata/pull/3457#discussion_r346207868
 
 

 ##########
 File path: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/createTable/TestCreateTableLike.scala
 ##########
 @@ -134,7 +134,9 @@ class TestCreateTableLike extends QueryTest with BeforeAndAfterEach with BeforeA
     assert(exception.getMessage.contains("already exists in database"))
   }
 
-  test("command with location") {
+  // ignore this test case since Spark 2.1 does not support specify location
+  // and also current implementation in carbon does not use this parameter.
 
 Review comment:
   If Spark version is 2.2 and above, then also this test will be ignored.  Instead you can use 'SparkUtil.isSparkVersionXandAbove("2.2")' in your test case and check for it. You can refer to the test class 'TestCreateTableUsingSparkCarbonFileFormat'.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services