[GitHub] [carbondata] manishnalla1994 opened a new pull request #3348: [CARBONDATA-3486] Fix Serialization/Deserialization issue with DataType

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] manishnalla1994 opened a new pull request #3348: [CARBONDATA-3486] Fix Serialization/Deserialization issue with DataType

GitBox
manishnalla1994 opened a new pull request #3348: [CARBONDATA-3486] Fix Serialization/Deserialization issue with DataType
URL: https://github.com/apache/carbondata/pull/3348
 
 
   Problem: When we use old store and do alter add sort columns on it then query on the old segment, serialization/de-serialization issue comes for Filter Column of Measure type which has been changed in Sort Column as it is being de-serialized by ObjectSerialization. This fails the check and the query.
   
   Solution: Checked the datatype based on Datatype ID and not on the object.
   
   Be sure to do all of the following checklist to help us incorporate
   your contribution quickly and easily:
   
    - [ ] Any interfaces changed?
   
    - [ ] Any backward compatibility impacted?
   
    - [ ] Document update required?
   
    - [x] Testing done
           Please provide details on
           - Whether new unit test cases have been added or why no new tests are required?
           - How it is tested? Please attach test report.
           - Is it a performance related change? Please attach the performance test report.
           - Any additional information to help reviewers in testing this change.
         
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services