[GitHub] [carbondata] marchpure commented on a change in pull request #3764: [CARBONDATA-3820] Fix CDC failure when sort columns present in source dataframe

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] marchpure commented on a change in pull request #3764: [CARBONDATA-3820] Fix CDC failure when sort columns present in source dataframe

GitBox

marchpure commented on a change in pull request #3764:
URL: https://github.com/apache/carbondata/pull/3764#discussion_r441254421



##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/mutation/merge/CarbonMergeDataSetCommand.scala
##########
@@ -267,7 +267,8 @@ case class CarbonMergeDataSetCommand(
         StructField(status_on_mergeds, IntegerType)))
     val factory =
       new SparkCarbonFileFormat().prepareWrite(sparkSession, job,
-        carbonTable.getTableInfo.getFactTable.getTableProperties.asScala.toMap, schema)
+        carbonTable.getTableInfo.getFactTable.getTableProperties.asScala

Review comment:
       Tested. empty map is good.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]