[GitHub] [carbondata] marchpure commented on a change in pull request #3764: [CARBONDATA-3820] Fix CDC failure when sort columns present in source dataframe

[GitBox]

marchpure commented on a change in pull request #3764:
URL: https://github.com/apache/carbondata/pull/3764#discussion_r441254460



##########
File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/merge/MergeTestCase.scala
##########
@@ -142,6 +159,22 @@ class MergeTestCase extends QueryTest with BeforeAndAfterAll {
     checkAnswer(sql("select count(*) from order where state = 2"), Seq(Row(2)))
   }
 
+  test("test basic merge into the globalsort table") {

Review comment:
       Added

##########
File path: examples/spark/src/main/scala/org/apache/carbondata/examples/CDCExample.scala
##########
@@ -141,6 +141,8 @@ object CDCExample {
         .write
         .format("carbondata")
         .option("tableName", "target")
+        .option("sort_scope", "global_sort")

Review comment:
       Changed




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]