marchpure opened a new pull request #3507: [CARBONDATA-3617] loadDataUsingGlobalSort should based on SortColumns…
URL:
https://github.com/apache/carbondata/pull/3507
… Instead Of Whole CarbonRow
Modification reason: During loading Data usesing globalsort, the sortby processing is based the whole carbon row, the overhead of gc is huge when there are many columns. Theoretically, the sortby processing can works well just based on the sort columns, which will brings less time overhead and gc overhead.
Modification content: In case of loadDataUsingGlobalSort, the first parameter of rdd.sortby is changed to CarbonRow.getKey from CarbonRow.getData. In CarbonRow.getKey, we get the sortcolumns of CarbonRow
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]
With regards,
Apache Git Services
Locked
