[GitHub] [carbondata] marchpure opened a new pull request #3549: [Carbondata-3643] Insert array('')/array() into Struct<Array> column …

[GitBox]

marchpure opened a new pull request #3549: [Carbondata-3643] Insert array('')/array() into Struct<Array> column …
URL: https://github.com/apache/carbondata/pull/3549
 
 
   …will result in array(null), which is inconsist with Parquet
   
   Modification reason: Result is incorrect when Inserting Select From a Parquet Table with a Struct with array('')/array(, The result shouldn't be array(null), while parquet results in array('') or array().
   
   Modification content: When the input value is Struct(""), the StructParserImpl handle the EMPTY STRING
   
    ### Why is this PR needed?
   
   
    ### What changes were proposed in this PR?
   
       
    ### Does this PR introduce any user interface change?
    - No
    - Yes. (please explain the change and update document)
   
    ### Is any new testcase added?
    - No
    - Yes
   
       
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3549: [Carbondata-3643] Insert array('')/array() into Struct<Array> column …
URL: https://github.com/apache/carbondata/pull/3549#issuecomment-569861903
 
 
   Build Success with Spark 2.1.0, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/1369/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3549: [Carbondata-3643] Insert array('')/array() into Struct<Array> column …
URL: https://github.com/apache/carbondata/pull/3549#issuecomment-569866482
 
 
   Build Failed with Spark 2.2.1, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/1379/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3549: [Carbondata-3643] Insert array('')/array() into Struct<Array> column …
URL: https://github.com/apache/carbondata/pull/3549#issuecomment-569869688
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1389/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

jackylk commented on issue #3549: [Carbondata-3643] Insert array('')/array() into Struct<Array> column …
URL: https://github.com/apache/carbondata/pull/3549#issuecomment-569872897
 
 
   please modify the PR description according to the template

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

jackylk commented on issue #3549: [Carbondata-3643] Insert array('')/array() into Struct<Array> column …
URL: https://github.com/apache/carbondata/pull/3549#issuecomment-569872912
 
 
   retest this please

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3549: [Carbondata-3643] Insert array('')/array() into Struct<Array> column …
URL: https://github.com/apache/carbondata/pull/3549#issuecomment-569880512
 
 
   Build Success with Spark 2.1.0, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/1371/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3549: [Carbondata-3643] Insert array('')/array() into Struct<Array> column …
URL: https://github.com/apache/carbondata/pull/3549#issuecomment-569886182
 
 
   Build Failed with Spark 2.2.1, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/1381/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3549: [Carbondata-3643] Insert array('')/array() into Struct<Array> column …
URL: https://github.com/apache/carbondata/pull/3549#issuecomment-569889786
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1391/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3549: [Carbondata-3643] Insert array('')/array() into Struct<Array> column …
URL: https://github.com/apache/carbondata/pull/3549#issuecomment-569909911
 
 
   Build Success with Spark 2.1.0, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/1375/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3549: [Carbondata-3643] Insert array('')/array() into Struct<Array> column …
URL: https://github.com/apache/carbondata/pull/3549#issuecomment-569910147
 
 
   Build Failed with Spark 2.2.1, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/1385/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3549: [Carbondata-3643] Insert array('')/array() into Struct<Array> column …
URL: https://github.com/apache/carbondata/pull/3549#issuecomment-569910170
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1396/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3549: [Carbondata-3643] Insert array('')/array() into Struct<Array> column …
URL: https://github.com/apache/carbondata/pull/3549#issuecomment-569963957
 
 
   Build Success with Spark 2.1.0, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/1382/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3549: [Carbondata-3643] Insert array('')/array() into Struct<Array> column …
URL: https://github.com/apache/carbondata/pull/3549#issuecomment-569970289
 
 
   Build Failed with Spark 2.2.1, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/1392/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3549: [Carbondata-3643] Insert array('')/array() into Struct<Array> column …
URL: https://github.com/apache/carbondata/pull/3549#issuecomment-569972329
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1404/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

ajantha-bhat commented on a change in pull request #3549: [Carbondata-3643] Insert array('')/array() into Struct<Array> column …
URL: https://github.com/apache/carbondata/pull/3549#discussion_r363564535
 
 

 ##########
 File path: processing/src/main/java/org/apache/carbondata/processing/loading/parser/impl/StructParserImpl.java
 ##########
 @@ -59,6 +59,14 @@ public StructObject parse(Object data) {
           }
           return new StructObject(array);
         }
+      } else if (value.isEmpty()) {
 
 Review comment:
   I just checked the code , **Need to handle the same for `MapParserImpl` also**. where as **ArrayParserImpl** is already handled this.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

marchpure closed pull request #3549: [Carbondata-3643] Insert array('')/array() into Struct<Array> column …
URL: https://github.com/apache/carbondata/pull/3549
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services