[GitHub] [carbondata] marchpure opened a new pull request #3660: [HOTFIX] Remove Useless filepath truncation During pruning

[GitBox]

marchpure opened a new pull request #3660: [HOTFIX] Remove Useless filepath truncation During pruning
URL: https://github.com/apache/carbondata/pull/3660
 
 
    ### Why is this PR needed?
    During prunning, for each blocklet, it will truncate the filepath with the keyword "/Part0". But it is meaningless.
   Specially, for partition table, the filepath is in style of '/tablename/partitionkey=value/segment0/.carbondata',  even have no keywork '/Part0'.
   For non-partition table, it is also meaningless to do this work.
   If there are a huge amount of blocklets, such as 400 million blocklets are going to be prunned, the truncation work hampers the query performance heavily.
   
    ### What changes were proposed in this PR?
   Remove the filepath truncation.
       
    ### Does this PR introduce any user interface change?
    - No
   
    ### Is any new testcase added?
    - No
   
       
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3660: [HOTFIX] Remove Useless filepath truncation During pruning
URL: https://github.com/apache/carbondata/pull/3660#issuecomment-595802540
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2358/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3660: [HOTFIX] Remove Useless filepath truncation During pruning
URL: https://github.com/apache/carbondata/pull/3660#issuecomment-595808010
 
 
   Build Failed  with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/653/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

marchpure commented on issue #3660: [HOTFIX] Remove Useless filepath truncation During pruning
URL: https://github.com/apache/carbondata/pull/3660#issuecomment-595856260
 
 
   retest this please

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3660: [HOTFIX] Remove Useless filepath truncation During pruning partition table
URL: https://github.com/apache/carbondata/pull/3660#issuecomment-595894988
 
 
   Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/655/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3660: [HOTFIX] Remove Useless filepath truncation During pruning partition table
URL: https://github.com/apache/carbondata/pull/3660#issuecomment-595896885
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2360/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

jackylk commented on issue #3660: [HOTFIX] Remove Useless filepath truncation During pruning partition table
URL: https://github.com/apache/carbondata/pull/3660#issuecomment-596159808
 
 
   LGTM

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

asfgit closed pull request #3660: [HOTFIX] Remove Useless filepath truncation During pruning partition table
URL: https://github.com/apache/carbondata/pull/3660
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services