nihal0107 commented on a change in pull request #3819:
URL:
https://github.com/apache/carbondata/pull/3819#discussion_r482003664##########
File path: sdk/sdk/src/main/java/org/apache/carbondata/sdk/file/CSVCarbonWriter.java
##########
@@ -72,6 +88,75 @@ public void write(Object object) throws IOException {
}
}
+ private CsvParser buildCsvParser(Configuration conf) {
+ CsvParserSettings settings = CSVInputFormat.extractCsvParserSettings(conf);
+ return new CsvParser(settings);
+ }
+
+ @Override
+ public void validateAndSetDataFiles(CarbonFile[] dataFiles) throws IOException {
Review comment:
I have changed the method name as `setDataFiles` but we have to expose this as public so that all the writer can use from `CarbonWriterBuilder`. Also, I have put this in carbonWriter because it will clean the code at the time of building the carbonWriter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]
Locked
