nihal0107 commented on a change in pull request #3865:
URL:
https://github.com/apache/carbondata/pull/3865#discussion_r474518906##########
File path: processing/src/main/java/org/apache/carbondata/processing/loading/converter/impl/RowConverterImpl.java
##########
@@ -130,9 +135,14 @@ public CarbonRow convert(CarbonRow row) throws CarbonDataLoadingException {
}
fieldConverters[i].convert(row, logHolder);
if (!logHolder.isLogged() && logHolder.isBadRecordNotAdded()) {
- badRecordLogger.addBadRecordsToBuilder(row.getRawData(), logHolder.getReason());
+ String reason = logHolder.getReason();
Review comment:
We have to set the record also in log and we don't pass the rawdata to `NonDictionaryFieldConverterImpl.convert()` . So we have to do formatting in `RowConverterImpl`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]
Locked
