[GitHub] [carbondata] nihal0107 opened a new pull request #3959: [CARBONDATA-4010] Doc changes for long strings as bad record.

[GitBox]

nihal0107 opened a new pull request #3959:
URL: https://github.com/apache/carbondata/pull/3959


    ### Why is this PR needed?
    Added documentation change for the handling of long strings(length greater than 32000) as bad record.
   
    ### What changes were proposed in this PR?
    Added documentation change for the handling of long strings(length greater than 32000) as bad record.
       
    ### Does this PR introduce any user interface change?
    - No
   
    ### Is any new testcase added?
    - No
   
       
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3959:
URL: https://github.com/apache/carbondata/pull/3959#issuecomment-698869602


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2471/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3959:
URL: https://github.com/apache/carbondata/pull/3959#issuecomment-698870185


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4214/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3959:
URL: https://github.com/apache/carbondata/pull/3959#issuecomment-698869602






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3959:
URL: https://github.com/apache/carbondata/pull/3959#issuecomment-703456259


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2548/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3959:
URL: https://github.com/apache/carbondata/pull/3959#issuecomment-703459809


   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4296/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

nihal0107 commented on pull request #3959:
URL: https://github.com/apache/carbondata/pull/3959#issuecomment-703596141


   restest this please.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3959:
URL: https://github.com/apache/carbondata/pull/3959#issuecomment-703659762


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4300/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3959:
URL: https://github.com/apache/carbondata/pull/3959#issuecomment-703666164


   Build Failed  with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2552/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

Indhumathi27 commented on a change in pull request #3959:
URL: https://github.com/apache/carbondata/pull/3959#discussion_r500099594



##########
File path: docs/ddl-of-carbondata.md
##########
@@ -426,7 +426,8 @@ CarbonData DDL statements are documented here,which includes:
    - ##### String longer than 32000 characters
 
      In common scenarios, the length of string is less than 32000,
-     so carbondata stores the length of content using Short to reduce memory and space consumption.
+     so carbondata stores the length of content using Short to reduce memory and space consumption, and it handles the strings
+     which length greater than 32000 as bad record. Refer [bad record handling](https://github.com/apache/carbondata/blob/master/docs/dml-of-carbondata.md#bad-records-handling) section for better understanding.

Review comment:
       ```suggestion
    and it handles strings which have length greater than 32000 as a bad record.
   
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

Indhumathi27 commented on a change in pull request #3959:
URL: https://github.com/apache/carbondata/pull/3959#discussion_r500099594



##########
File path: docs/ddl-of-carbondata.md
##########
@@ -426,7 +426,8 @@ CarbonData DDL statements are documented here,which includes:
    - ##### String longer than 32000 characters
 
      In common scenarios, the length of string is less than 32000,
-     so carbondata stores the length of content using Short to reduce memory and space consumption.
+     so carbondata stores the length of content using Short to reduce memory and space consumption, and it handles the strings
+     which length greater than 32000 as bad record. Refer [bad record handling](https://github.com/apache/carbondata/blob/master/docs/dml-of-carbondata.md#bad-records-handling) section for better understanding.

Review comment:
       ```suggestion
    and it handles strings which have length greater than 32000 as a bad record. Refer [bad record handling](https://github.com/apache/carbondata/blob/master/docs/dml-of-carbondata.md#bad-records-handling) section for better understanding.
   
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

nihal0107 commented on a change in pull request #3959:
URL: https://github.com/apache/carbondata/pull/3959#discussion_r500254558



##########
File path: docs/ddl-of-carbondata.md
##########
@@ -426,7 +426,8 @@ CarbonData DDL statements are documented here,which includes:
    - ##### String longer than 32000 characters
 
      In common scenarios, the length of string is less than 32000,
-     so carbondata stores the length of content using Short to reduce memory and space consumption.
+     so carbondata stores the length of content using Short to reduce memory and space consumption, and it handles the strings
+     which length greater than 32000 as bad record. Refer [bad record handling](https://github.com/apache/carbondata/blob/master/docs/dml-of-carbondata.md#bad-records-handling) section for better understanding.

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3959:
URL: https://github.com/apache/carbondata/pull/3959#issuecomment-704324417


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2566/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3959:
URL: https://github.com/apache/carbondata/pull/3959#issuecomment-704325591


   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4316/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

Indhumathi27 commented on pull request #3959:
URL: https://github.com/apache/carbondata/pull/3959#issuecomment-704743825


   retest  this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3959:
URL: https://github.com/apache/carbondata/pull/3959#issuecomment-704798161


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4320/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3959:
URL: https://github.com/apache/carbondata/pull/3959#issuecomment-704799730


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2570/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

Indhumathi27 commented on a change in pull request #3959:
URL: https://github.com/apache/carbondata/pull/3959#discussion_r501090468



##########
File path: docs/ddl-of-carbondata.md
##########
@@ -812,7 +813,19 @@ Users can specify which columns to include and exclude for local dictionary gene
        ```
        ALTER TABLE tablename UNSET TBLPROPERTIES('SORT_SCOPE')
        ```
+     - ##### Long String Columns
+       Example to SET Long String Columns:
+       ```
+       ALTER TABLE tablename SET TBLPROPERTIES('LONG_STRING_COLUMNS'='column1')
+       ```
+       **NOTE:** Only string columns can be set to long string columns. Cannot set sort columns to long string columns.
 
+       Example to UNSET Long String Columns:
+       ```
+       ALTER TABLE tablename UNSET TBLPROPERTIES('LONG_STRING_COLUMNS')
+       ```
+       **NOTE:** On unset long string columns are set to their original datatypes.

Review comment:
       ```suggestion
          **NOTE:** On unset, long string columns are set to their original datatypes.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

nihal0107 commented on a change in pull request #3959:
URL: https://github.com/apache/carbondata/pull/3959#discussion_r501158701



##########
File path: docs/ddl-of-carbondata.md
##########
@@ -812,7 +813,19 @@ Users can specify which columns to include and exclude for local dictionary gene
        ```
        ALTER TABLE tablename UNSET TBLPROPERTIES('SORT_SCOPE')
        ```
+     - ##### Long String Columns
+       Example to SET Long String Columns:
+       ```
+       ALTER TABLE tablename SET TBLPROPERTIES('LONG_STRING_COLUMNS'='column1')
+       ```
+       **NOTE:** Only string columns can be set to long string columns. Cannot set sort columns to long string columns.
 
+       Example to UNSET Long String Columns:
+       ```
+       ALTER TABLE tablename UNSET TBLPROPERTIES('LONG_STRING_COLUMNS')
+       ```
+       **NOTE:** On unset long string columns are set to their original datatypes.

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3959:
URL: https://github.com/apache/carbondata/pull/3959#issuecomment-705119554


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4332/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]