[GitHub] [carbondata] niuge01 commented on a change in pull request #3692: [CARBONDATA-3776] Clean old materialized view implementation

[GitBox]

niuge01 commented on a change in pull request #3692:
URL: https://github.com/apache/carbondata/pull/3692#discussion_r412139045



##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/index/CarbonCreateIndexCommand.scala
##########
@@ -85,7 +85,7 @@ case class CarbonCreateIndexCommand(
       throw new MalformedCarbonCommandException("Unsupported operation on non transactional table")
     }
 
-    if (parentTable.isMVTable || parentTable.isIndexTable) {
+    if (parentTable.isIndexTable) {

Review comment:
       OK

##########
File path: integration/spark/src/test/scala/org/apache/carbondata/view/rewrite/MVCreateTestCase.scala
##########
@@ -1242,7 +1241,6 @@ class MVCreateTestCase extends QueryTest with BeforeAndAfterAll {
     val df2 = sql(
       " select cast(floor((m_month +1000) / 900) * 900 - 2000 AS INT),c_code as abc  from maintable")
     assert(TestUtil.verifyMVHit(df1.queryExecution.optimizedPlan, "da_cast"))
-    assert(TestUtil.verifyMVHit(df2.queryExecution.optimizedPlan, "da_cast"))

Review comment:
       OK

##########
File path: integration/spark/src/test/scala/org/apache/carbondata/view/rewrite/MVCreateTestCase.scala
##########
@@ -1272,8 +1270,6 @@ class MVCreateTestCase extends QueryTest with BeforeAndAfterAll {
     checkAnswer(sql("select cast(m_month + 1000 AS INT) as a, c_code as abc from maintable"), Seq(Row(1010, "xxx")))
     var df1 = sql("select cast(m_month + 1000 AS INT) as a, c_code as abc from maintable")
     assert(TestUtil.verifyMVHit(df1.queryExecution.optimizedPlan, "da_cast"))
-    df1 = sql("select cast(m_month + 1000 AS INT), c_code from maintable")

Review comment:
       OK

##########
File path: integration/spark/src/test/scala/org/apache/carbondata/view/rewrite/matching/TestSQLBatch.scala
##########
@@ -1,21 +1,4 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements.  See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License.  You may obtain a copy of the License at
- *

Review comment:
       OK

##########
File path: integration/spark/src/test/scala/org/apache/carbondata/view/rewrite/matching/TestTPCDS_1_4_Batch.scala
##########
@@ -1,4 +1,4 @@
-package org.apache.carbondata.mv.rewrite.matching
+package org.apache.carbondata.view.rewrite.matching

Review comment:
       Ok

##########
File path: integration/spark/src/test/scala/org/apache/carbondata/view/testutil/TestSQLBatch.scala
##########
@@ -1,35 +1,18 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements.  See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License.  You may obtain a copy of the License at
- *
- *    http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

Review comment:
       Ok

##########
File path: integration/spark/src/test/scala/org/apache/carbondata/view/testutil/TestSQLBatch2.scala
##########
@@ -1,35 +1,18 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements.  See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License.  You may obtain a copy of the License at
- *
- *    http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,

Review comment:
       OK

##########
File path: integration/spark/src/test/scala/org/apache/carbondata/view/testutil/Tpcds_1_4_QueryBatch.scala
##########
@@ -1,21 +1,4 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements.  See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License.  You may obtain a copy of the License at
- *
- *    http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

Review comment:
       OK




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]