[GitHub] [carbondata] niuge01 commented on a change in pull request #3692: [CARBONDATA-3776] Clean old materialized view implementation

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] niuge01 commented on a change in pull request #3692: [CARBONDATA-3776] Clean old materialized view implementation

GitBox

niuge01 commented on a change in pull request #3692:
URL: https://github.com/apache/carbondata/pull/3692#discussion_r412770345



##########
File path: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
##########
@@ -2249,11 +2249,6 @@ private CarbonCommonConstants() {
    */
   public static final String MV_NAME = "mv_name";
 
-  /**

Review comment:
       OK

##########
File path: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/IndexSchema.java
##########
@@ -90,21 +72,6 @@
    */
   protected TableSchema childSchema;
 
-  /**
-   * main table column list mapped to index table

Review comment:
       OK




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]