[GitHub] [carbondata] niuge01 opened a new pull request #3661: [WIP] Support materialized view
Locked
1 ...
6789101112
1 ...
6789101112
 
|
ajantha-bhat commented on a change in pull request #3661: [WIP] Support materialized view
URL: https://github.com/apache/carbondata/pull/3661#discussion_r399963004 ########## File path: core/src/main/java/org/apache/carbondata/core/datamap/DataMapStoreManager.java ########## @@ -163,6 +165,17 @@ private DataMapStoreManager() { return provider.retrieveAllSchemas(); } + /** + * Return first match of the specified index name in table + * + */ + public Optional<DataMapSchema> getIndexInTable(CarbonTable carbonTable, String indexName) Review comment: DataMapSchema need to change to IndexSchema ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] With regards, Apache Git Services |
|
|
In reply to this post by GitBox
ajantha-bhat commented on a change in pull request #3661: [WIP] Support materialized view
URL: https://github.com/apache/carbondata/pull/3661#discussion_r399963875 ########## File path: core/src/main/java/org/apache/carbondata/core/datamap/IndexChooser.java ########## @@ -59,76 +59,76 @@ * the datamap which has fewer columns that is the first datamap. */ @InterfaceAudience.Internal -public class DataMapChooser { +public class IndexChooser { private CarbonTable carbonTable; - private List<TableDataMap> cgDataMaps; - private List<TableDataMap> fgDataMaps; + private List<TableIndex> cgIndexes; + private List<TableIndex> fgIndexes; - public DataMapChooser(CarbonTable carbonTable) throws IOException { + public IndexChooser(CarbonTable carbonTable) throws IOException { this.carbonTable = carbonTable; - // read all datamaps for this table and populate CG and FG datamap list - List<TableDataMap> visibleDataMaps = - DataMapStoreManager.getInstance().getAllVisibleDataMap(carbonTable); + // read all indexes for this table and populate CG and FG index list + List<TableIndex> visibleIndexes = + DataMapStoreManager.getInstance().getAllVisibleIndexes(carbonTable); Review comment: DataMapStoreManager need to be changed to IndexStoreManager ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] With regards, Apache Git Services |
|
|
In reply to this post by GitBox
ajantha-bhat commented on a change in pull request #3661: [WIP] Support materialized view
URL: https://github.com/apache/carbondata/pull/3661#discussion_r399965545 ########## File path: core/src/main/java/org/apache/carbondata/core/datamap/dev/DataMapSyncStatus.java ########## @@ -36,7 +36,7 @@ /** * Interface to check whether datamap can be enabled */ -@InterfaceAudience.Developer("DataMap") +@InterfaceAudience.Developer("Index") Review comment: please delete old mv also in this PR ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] With regards, Apache Git Services |
|
|
In reply to this post by GitBox
ajantha-bhat commented on a change in pull request #3661: [WIP] Support materialized view
URL: https://github.com/apache/carbondata/pull/3661#discussion_r399968880 ########## File path: dev/findbugs-exclude.xml ########## @@ -59,7 +59,7 @@ <Bug pattern="STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE"/> </Match> <Match> - <Class name="org.apache.carbondata.core.datamap.DistributableDataMapFormat"/> + <Class name="org.apache.carbondata.core.datamap.IndexInputFormat"/> Review comment: Also documents [*.md] files need to be updated ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] With regards, Apache Git Services |
|
|
In reply to this post by GitBox
ajantha-bhat commented on a change in pull request #3661: [WIP] Support materialized view
URL: https://github.com/apache/carbondata/pull/3661#discussion_r399968880 ########## File path: dev/findbugs-exclude.xml ########## @@ -59,7 +59,7 @@ <Bug pattern="STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE"/> </Match> <Match> - <Class name="org.apache.carbondata.core.datamap.DistributableDataMapFormat"/> + <Class name="org.apache.carbondata.core.datamap.IndexInputFormat"/> Review comment: Also documents [*.md] files need to be updated for all the changes of this PR ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] With regards, Apache Git Services |
|
|
In reply to this post by GitBox
ajantha-bhat commented on a change in pull request #3661: [WIP] Support materialized view
URL: https://github.com/apache/carbondata/pull/3661#discussion_r399969838 ########## File path: dev/findbugs-exclude.xml ########## @@ -59,7 +59,7 @@ <Bug pattern="STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE"/> </Match> <Match> - <Class name="org.apache.carbondata.core.datamap.DistributableDataMapFormat"/> + <Class name="org.apache.carbondata.core.datamap.IndexInputFormat"/> Review comment: Example, index-developer-guide.md has many datamap words in it still ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] With regards, Apache Git Services |
|
|
In reply to this post by GitBox
ajantha-bhat commented on a change in pull request #3661: [WIP] Support materialized view
URL: https://github.com/apache/carbondata/pull/3661#discussion_r399970121 ########## File path: docs/index-developer-guide.md ########## @@ -24,11 +24,11 @@ Currently, there are two types of DataMap supported: 2. MVDataMap: DataMap that leverages Materialized View to accelerate olap style query, like SPJG query (select, predicate, join, groupby). Preaggregate, timeseries and mv DataMap belong to this type of DataMaps. Review comment: Also documents [*.md] files need to be updated for all the changes of this PR Example, index-developer-guide.md has many datamap words in it still ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] With regards, Apache Git Services |
|
|
In reply to this post by GitBox
ajantha-bhat commented on a change in pull request #3661: [WIP] Support materialized view
URL: https://github.com/apache/carbondata/pull/3661#discussion_r399968880 ########## File path: dev/findbugs-exclude.xml ########## @@ -59,7 +59,7 @@ <Bug pattern="STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE"/> </Match> <Match> - <Class name="org.apache.carbondata.core.datamap.DistributableDataMapFormat"/> + <Class name="org.apache.carbondata.core.datamap.IndexInputFormat"/> Review comment: Also documents [*.md] files need to be updated for all the changes of this PR ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] With regards, Apache Git Services |
|
|
In reply to this post by GitBox
ajantha-bhat commented on a change in pull request #3661: [WIP] Support materialized view
URL: https://github.com/apache/carbondata/pull/3661#discussion_r399969838 ########## File path: dev/findbugs-exclude.xml ########## @@ -59,7 +59,7 @@ <Bug pattern="STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE"/> </Match> <Match> - <Class name="org.apache.carbondata.core.datamap.DistributableDataMapFormat"/> + <Class name="org.apache.carbondata.core.datamap.IndexInputFormat"/> Review comment: Example, index-developer-guide.md has many datamap words in it still ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] With regards, Apache Git Services |
|
|
In reply to this post by GitBox
ajantha-bhat commented on a change in pull request #3661: [WIP] Support materialized view
URL: https://github.com/apache/carbondata/pull/3661#discussion_r399971835 ########## File path: integration/spark/src/test/scala/org/apache/carbondata/view/MaterializedViewTest.scala ########## @@ -0,0 +1,194 @@ +package org.apache.carbondata.view + +import java.io.File + +import org.apache.spark.sql.catalyst.analysis.TableAlreadyExistsException +import org.apache.spark.sql.catalyst.catalog.HiveTableRelation +import org.apache.spark.sql.catalyst.plans.logical.LogicalPlan +import org.apache.spark.sql.execution.datasources.LogicalRelation +import org.apache.spark.sql.test.util.QueryTest +import org.scalatest.BeforeAndAfterAll + +import org.apache.carbondata.core.constants.CarbonCommonConstants +import org.apache.carbondata.core.util.CarbonProperties +import org.apache.carbondata.spark.exception.ProcessMetaDataException + +class MaterializedViewTest extends QueryTest with BeforeAndAfterAll { + + override def beforeAll { + drop() + CarbonProperties.getInstance() + .addProperty(CarbonCommonConstants.CARBON_TIMESTAMP_FORMAT, "yyyy/MM/dd") + val projectPath = new File(this.getClass.getResource("/").getPath + "../../../../") + .getCanonicalPath.replaceAll("\\\\", "/") + val integrationPath = s"$projectPath/integration" + val resourcesPath = s"$integrationPath/spark/src/test/resources" + sql( + """ + | CREATE TABLE fact_table (empname String, designation String, doj Timestamp, + | workgroupcategory int, workgroupcategoryname String, deptno int, deptname String, + | projectcode int, projectjoindate Timestamp, projectenddate Timestamp,attendance int, + | utilization int,salary int) + | STORED AS carbondata + """.stripMargin) + sql(s"""LOAD DATA local inpath '$resourcesPath/data_big.csv' INTO TABLE fact_table OPTIONS('DELIMITER'= ',', 'QUOTECHAR'= '"')""") + sql(s"""LOAD DATA local inpath '$resourcesPath/data_big.csv' INTO TABLE fact_table OPTIONS('DELIMITER'= ',', 'QUOTECHAR'= '"')""") + } + + test("test create mv on hive table") { + sql("drop materialized view if exists mv1") + sql("drop table if exists source") + sql("create table source as select * from fact_table") + sql("create materialized view mv1 as select empname, deptname, avg(salary) from source group by empname, deptname") Review comment: Now that hive mv and our mv syntax is same. what is the impcat ? On hive table even if we want to create hive mv. Does it create carbon mv table ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] With regards, Apache Git Services |
|
|
In reply to this post by GitBox
ajantha-bhat commented on a change in pull request #3661: [WIP] Support materialized view
URL: https://github.com/apache/carbondata/pull/3661#discussion_r399972261 ########## File path: integration/spark/src/test/scala/org/apache/carbondata/view/MaterializedViewTest.scala ########## @@ -0,0 +1,194 @@ +package org.apache.carbondata.view + +import java.io.File + +import org.apache.spark.sql.catalyst.analysis.TableAlreadyExistsException +import org.apache.spark.sql.catalyst.catalog.HiveTableRelation +import org.apache.spark.sql.catalyst.plans.logical.LogicalPlan +import org.apache.spark.sql.execution.datasources.LogicalRelation +import org.apache.spark.sql.test.util.QueryTest +import org.scalatest.BeforeAndAfterAll + +import org.apache.carbondata.core.constants.CarbonCommonConstants +import org.apache.carbondata.core.util.CarbonProperties +import org.apache.carbondata.spark.exception.ProcessMetaDataException + +class MaterializedViewTest extends QueryTest with BeforeAndAfterAll { + + override def beforeAll { + drop() + CarbonProperties.getInstance() + .addProperty(CarbonCommonConstants.CARBON_TIMESTAMP_FORMAT, "yyyy/MM/dd") + val projectPath = new File(this.getClass.getResource("/").getPath + "../../../../") + .getCanonicalPath.replaceAll("\\\\", "/") + val integrationPath = s"$projectPath/integration" + val resourcesPath = s"$integrationPath/spark/src/test/resources" + sql( + """ + | CREATE TABLE fact_table (empname String, designation String, doj Timestamp, + | workgroupcategory int, workgroupcategoryname String, deptno int, deptname String, + | projectcode int, projectjoindate Timestamp, projectenddate Timestamp,attendance int, + | utilization int,salary int) + | STORED AS carbondata + """.stripMargin) + sql(s"""LOAD DATA local inpath '$resourcesPath/data_big.csv' INTO TABLE fact_table OPTIONS('DELIMITER'= ',', 'QUOTECHAR'= '"')""") + sql(s"""LOAD DATA local inpath '$resourcesPath/data_big.csv' INTO TABLE fact_table OPTIONS('DELIMITER'= ',', 'QUOTECHAR'= '"')""") + } + + test("test create mv on hive table") { + sql("drop materialized view if exists mv1") + sql("drop table if exists source") + sql("create table source as select * from fact_table") + sql("create materialized view mv1 as select empname, deptname, avg(salary) from source group by empname, deptname") Review comment: do we support all the feature supported in hive mv ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] With regards, Apache Git Services |
|
|
In reply to this post by GitBox
ajantha-bhat commented on a change in pull request #3661: [WIP] Support materialized view
URL: https://github.com/apache/carbondata/pull/3661#discussion_r399971835 ########## File path: integration/spark/src/test/scala/org/apache/carbondata/view/MaterializedViewTest.scala ########## @@ -0,0 +1,194 @@ +package org.apache.carbondata.view + +import java.io.File + +import org.apache.spark.sql.catalyst.analysis.TableAlreadyExistsException +import org.apache.spark.sql.catalyst.catalog.HiveTableRelation +import org.apache.spark.sql.catalyst.plans.logical.LogicalPlan +import org.apache.spark.sql.execution.datasources.LogicalRelation +import org.apache.spark.sql.test.util.QueryTest +import org.scalatest.BeforeAndAfterAll + +import org.apache.carbondata.core.constants.CarbonCommonConstants +import org.apache.carbondata.core.util.CarbonProperties +import org.apache.carbondata.spark.exception.ProcessMetaDataException + +class MaterializedViewTest extends QueryTest with BeforeAndAfterAll { + + override def beforeAll { + drop() + CarbonProperties.getInstance() + .addProperty(CarbonCommonConstants.CARBON_TIMESTAMP_FORMAT, "yyyy/MM/dd") + val projectPath = new File(this.getClass.getResource("/").getPath + "../../../../") + .getCanonicalPath.replaceAll("\\\\", "/") + val integrationPath = s"$projectPath/integration" + val resourcesPath = s"$integrationPath/spark/src/test/resources" + sql( + """ + | CREATE TABLE fact_table (empname String, designation String, doj Timestamp, + | workgroupcategory int, workgroupcategoryname String, deptno int, deptname String, + | projectcode int, projectjoindate Timestamp, projectenddate Timestamp,attendance int, + | utilization int,salary int) + | STORED AS carbondata + """.stripMargin) + sql(s"""LOAD DATA local inpath '$resourcesPath/data_big.csv' INTO TABLE fact_table OPTIONS('DELIMITER'= ',', 'QUOTECHAR'= '"')""") + sql(s"""LOAD DATA local inpath '$resourcesPath/data_big.csv' INTO TABLE fact_table OPTIONS('DELIMITER'= ',', 'QUOTECHAR'= '"')""") + } + + test("test create mv on hive table") { + sql("drop materialized view if exists mv1") + sql("drop table if exists source") + sql("create table source as select * from fact_table") + sql("create materialized view mv1 as select empname, deptname, avg(salary) from source group by empname, deptname") Review comment: Now that hive mv and our mv syntax is same. what is the impact ? On hive table even if we want to create hive mv. Does it create carbon mv table ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] With regards, Apache Git Services |
|
|
In reply to this post by GitBox
Indhumathi27 commented on issue #3661: [WIP] Support materialized view
URL: https://github.com/apache/carbondata/pull/3661#issuecomment-606019193 @niuge01 Please describe what all index related changes are done in this PR also ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] With regards, Apache Git Services |
|
|
In reply to this post by GitBox
Indhumathi27 edited a comment on issue #3661: [WIP] Support materialized view
URL: https://github.com/apache/carbondata/pull/3661#issuecomment-606019193 @niuge01 @jackylk Please describe what all index related changes are done in this PR also ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] With regards, Apache Git Services |
|
|
In reply to this post by GitBox
niuge01 commented on a change in pull request #3661: [WIP] Support materialized view
URL: https://github.com/apache/carbondata/pull/3661#discussion_r400626587 ########## File path: core/src/main/java/org/apache/carbondata/core/datamap/DataMapStoreManager.java ########## @@ -163,6 +165,17 @@ private DataMapStoreManager() { return provider.retrieveAllSchemas(); } + /** + * Return first match of the specified index name in table + * + */ + public Optional<DataMapSchema> getIndexInTable(CarbonTable carbonTable, String indexName) Review comment: Yes, it will be changed in a new pr. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] With regards, Apache Git Services |
|
|
In reply to this post by GitBox
niuge01 commented on a change in pull request #3661: [WIP] Support materialized view
URL: https://github.com/apache/carbondata/pull/3661#discussion_r400626624 ########## File path: core/src/main/java/org/apache/carbondata/core/datamap/IndexChooser.java ########## @@ -59,76 +59,76 @@ * the datamap which has fewer columns that is the first datamap. */ @InterfaceAudience.Internal -public class DataMapChooser { +public class IndexChooser { private CarbonTable carbonTable; - private List<TableDataMap> cgDataMaps; - private List<TableDataMap> fgDataMaps; + private List<TableIndex> cgIndexes; + private List<TableIndex> fgIndexes; - public DataMapChooser(CarbonTable carbonTable) throws IOException { + public IndexChooser(CarbonTable carbonTable) throws IOException { this.carbonTable = carbonTable; - // read all datamaps for this table and populate CG and FG datamap list - List<TableDataMap> visibleDataMaps = - DataMapStoreManager.getInstance().getAllVisibleDataMap(carbonTable); + // read all indexes for this table and populate CG and FG index list + List<TableIndex> visibleIndexes = + DataMapStoreManager.getInstance().getAllVisibleIndexes(carbonTable); Review comment: Yes, it will be changed in a new pr. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] With regards, Apache Git Services |
|
|
In reply to this post by GitBox
Indhumathi27 commented on a change in pull request #3661: [CARBONDATA-3704] Support create materialized view on all type table, and make mv support mutil-tenant.
URL: https://github.com/apache/carbondata/pull/3661#discussion_r400663521 ########## File path: core/src/main/java/org/apache/carbondata/core/datamap/IndexChooser.java ########## @@ -59,76 +59,76 @@ * the datamap which has fewer columns that is the first datamap. */ @InterfaceAudience.Internal -public class DataMapChooser { +public class IndexChooser { private CarbonTable carbonTable; - private List<TableDataMap> cgDataMaps; - private List<TableDataMap> fgDataMaps; + private List<TableIndex> cgIndexes; + private List<TableIndex> fgIndexes; - public DataMapChooser(CarbonTable carbonTable) throws IOException { + public IndexChooser(CarbonTable carbonTable) throws IOException { this.carbonTable = carbonTable; - // read all datamaps for this table and populate CG and FG datamap list - List<TableDataMap> visibleDataMaps = - DataMapStoreManager.getInstance().getAllVisibleDataMap(carbonTable); + // read all indexes for this table and populate CG and FG index list + List<TableIndex> visibleIndexes = + DataMapStoreManager.getInstance().getAllVisibleIndexes(carbonTable); Map<String, DataMapStatusDetail> map = DataMapStatusManager.readDataMapStatusMap(); - cgDataMaps = new ArrayList<>(visibleDataMaps.size()); - fgDataMaps = new ArrayList<>(visibleDataMaps.size()); - for (TableDataMap visibleDataMap : visibleDataMaps) { - DataMapStatusDetail status = map.get(visibleDataMap.getDataMapSchema().getDataMapName()); + cgIndexes = new ArrayList<>(visibleIndexes.size()); + fgIndexes = new ArrayList<>(visibleIndexes.size()); + for (TableIndex visibleIndex : visibleIndexes) { + DataMapStatusDetail status = map.get(visibleIndex.getDataMapSchema().getDataMapName()); if (status != null && status.isEnabled()) { - DataMapLevel level = visibleDataMap.getDataMapFactory().getDataMapLevel(); - if (level == DataMapLevel.CG) { - cgDataMaps.add(visibleDataMap); + IndexLevel level = visibleIndex.getIndexFactory().getDataMapLevel(); + if (level == IndexLevel.CG) { + cgIndexes.add(visibleIndex); } else { - fgDataMaps.add(visibleDataMap); + fgIndexes.add(visibleIndex); } } } } /** - * Return a chosen datamap based on input filter. See {@link DataMapChooser} + * Return a chosen datamap based on input filter. See {@link IndexChooser} */ - public DataMapExprWrapper choose(FilterResolverIntf filter) { + public IndexExprWrapper choose(FilterResolverIntf filter) { if (filter != null) { Expression expression = filter.getFilterExpression(); // First check for FG datamaps if any exist - ExpressionTuple tuple = selectDataMap(expression, fgDataMaps, filter); - if (tuple.dataMapExprWrapper == null) { + ExpressionTuple tuple = selectDataMap(expression, fgIndexes, filter); + if (tuple.indexExprWrapper == null) { // Check for CG datamap - tuple = selectDataMap(expression, cgDataMaps, filter); + tuple = selectDataMap(expression, cgIndexes, filter); } - if (tuple.dataMapExprWrapper != null) { - return tuple.dataMapExprWrapper; + if (tuple.indexExprWrapper != null) { + return tuple.indexExprWrapper; } } // Return the default datamap if no other datamap exists. - return new DataMapExprWrapperImpl( - DataMapStoreManager.getInstance().getDefaultDataMap(carbonTable), filter); + return new IndexExprWrapperImpl( + DataMapStoreManager.getInstance().getDefaultIndex(carbonTable), filter); } /** - * Return a chosen FG datamap based on input filter. See {@link DataMapChooser} + * Return a chosen FG datamap based on input filter. See {@link IndexChooser} */ - public DataMapExprWrapper chooseFGDataMap(FilterResolverIntf resolverIntf) { - return chooseDataMap(DataMapLevel.FG, resolverIntf); + public IndexExprWrapper chooseFGDataMap(FilterResolverIntf resolverIntf) { + return chooseDataMap(IndexLevel.FG, resolverIntf); } /** - * Return a chosen CG datamap based on input filter. See {@link DataMapChooser} + * Return a chosen CG datamap based on input filter. See {@link IndexChooser} */ - public DataMapExprWrapper chooseCGDataMap(FilterResolverIntf resolverIntf) { - return chooseDataMap(DataMapLevel.CG, resolverIntf); + public IndexExprWrapper chooseCGDataMap(FilterResolverIntf resolverIntf) { + return chooseDataMap(IndexLevel.CG, resolverIntf); } - DataMapExprWrapper chooseDataMap(DataMapLevel level, FilterResolverIntf resolverIntf) { + IndexExprWrapper chooseDataMap(IndexLevel level, FilterResolverIntf resolverIntf) { if (resolverIntf != null) { Expression expression = resolverIntf.getFilterExpression(); - List<TableDataMap> datamaps = level == DataMapLevel.CG ? cgDataMaps : fgDataMaps; + List<TableIndex> datamaps = level == IndexLevel.CG ? cgIndexes : fgIndexes; Review comment: change variable name also to indexes ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] With regards, Apache Git Services |
|
|
In reply to this post by GitBox
CarbonDataQA1 commented on issue #3661: [CARBONDATA-3704] Support create materialized view on all type table, and make mv support mutil-tenant.
URL: https://github.com/apache/carbondata/pull/3661#issuecomment-606426926 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/887/ ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] With regards, Apache Git Services |
|
|
In reply to this post by GitBox
CarbonDataQA1 commented on issue #3661: [CARBONDATA-3704] Support create materialized view on all type table, and make mv support mutil-tenant.
URL: https://github.com/apache/carbondata/pull/3661#issuecomment-606428588 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2595/ ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] With regards, Apache Git Services |
|
|
In reply to this post by GitBox
niuge01 commented on a change in pull request #3661: [CARBONDATA-3704] Support create materialized view on all type table, and make mv support mutil-tenant.
URL: https://github.com/apache/carbondata/pull/3661#discussion_r400679356 ########## File path: docs/index-developer-guide.md ########## @@ -24,11 +24,11 @@ Currently, there are two types of DataMap supported: 2. MVDataMap: DataMap that leverages Materialized View to accelerate olap style query, like SPJG query (select, predicate, join, groupby). Preaggregate, timeseries and mv DataMap belong to this type of DataMaps. Review comment: Yes, it will be changed in a new pr. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] With regards, Apache Git Services |
«
Return to Apache CarbonData JIRA issues
|
1 view|%1 views
| Free forum by Nabble | Edit this page |