[GitHub] [carbondata] nstang01 opened a new pull request #3926: [CARBONDATA-3976]CarbonData Update operation enhancement

[GitBox]

nstang01 opened a new pull request #3926:
URL: https://github.com/apache/carbondata/pull/3926


    ### Why is this PR needed?
    Update operation will clean up delta files before update( see
   cleanUpDeltaFiles(carbonTable, false)), It's loop traversal metadata path
   and segment path many times. When there are too many files, the overhead
   will increase and update time will be longer.
   
    ### What changes were proposed in this PR?
   
   In cleanUpDeltaFiles have some same points in get files method, like
   updateStatusManager.getUpdateDeltaFilesList(segment,
   false,CarbonCommonConstants.UPDATE_DELTA_FILE_EXT, true,
   allSegmentFiles,true) and
   updateStatusManager.getUpdateDeltaFilesList(segment,
   false,CarbonCommonConstants.UPDATE_INDEX_FILE_EXT, true,
   allSegmentFiles,true), They are just different file types，but loop traversal
   segment path twice. we can merge it.
       
    ### Does this PR introduce any user interface change?
    - No
    - Yes. (please explain the change and update document)
   
    ### Is any new testcase added?
    - No
    - Yes
   
       
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3926:
URL: https://github.com/apache/carbondata/pull/3926#issuecomment-691908841


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

brijoobopanna commented on pull request #3926:
URL: https://github.com/apache/carbondata/pull/3926#issuecomment-692202971


   add to whitelist
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3926:
URL: https://github.com/apache/carbondata/pull/3926#issuecomment-692204608


   Build Failed  with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2330/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3926:
URL: https://github.com/apache/carbondata/pull/3926#issuecomment-692205105


   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4069/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3926:
URL: https://github.com/apache/carbondata/pull/3926#issuecomment-692459084


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2331/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3926:
URL: https://github.com/apache/carbondata/pull/3926#issuecomment-692459941


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4070/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

ajantha-bhat commented on pull request #3926:
URL: https://github.com/apache/carbondata/pull/3926#issuecomment-725200507


   @nstang01 , Is this different than #3986 ?? If same may be you can close this PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]