[GitHub] carbondata pull request #1007: [CARBONDATA-1146] Handling of the v3 format i...

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1007
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2344/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravikiran23 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1007#discussion_r121261502
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/reader/CarbonDeleteFilesDataReader.java ---
    @@ -80,8 +79,8 @@ private void initThreadPoolSize() {
        * @return
        * @throws Exception
        */
    -  public int[] getDeleteDataFromAllFiles(List<String> deltaFiles, String blockletId)
    -      throws Exception {
    +  public Map<String, Integer[]> getDeleteDataFromAllFiles(List<String> deltaFiles,
    --- End diff --
   
    DONE


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravikiran23 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1007#discussion_r121261509
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/cache/update/BlockletLevelDeleteDeltaDataCache.java ---
    @@ -17,26 +17,36 @@
     
     package org.apache.carbondata.core.cache.update;
     
    +import java.util.HashMap;
    +import java.util.Map;
    +
    +import org.apache.carbondata.core.constants.CarbonCommonConstants;
    +
     import org.roaringbitmap.RoaringBitmap;
     
     /**
      * This class maintains delete delta data cache of each blocklet along with the block timestamp
      */
     public class BlockletLevelDeleteDeltaDataCache {
    -  private RoaringBitmap deleteDelataDataCache;
    +  private Map<String, RoaringBitmap> deleteDelataDataCache =
    --- End diff --
   
    DONE


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravikiran23 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1007#discussion_r121261511
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/mutate/DeleteDeltaBlockletDetails.java ---
    @@ -31,6 +31,8 @@
     
       private static final long serialVersionUID = 1206104914911491724L;
       private String id;
    +  private String pageId;
    --- End diff --
   
    DONE


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1007
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2345/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit commented on the issue:

    https://github.com/apache/carbondata/pull/1007
 
   
    Refer to this link for build results (access rights to CI server needed):
    https://builds.apache.org/job/carbondata-pr-spark-1.6/223/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravikiran23 closed the pull request at:

    https://github.com/apache/carbondata/pull/1007


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

GitHub user ravikiran23 reopened a pull request:

    https://github.com/apache/carbondata/pull/1007

    [CARBONDATA-1146] Handling of the v3 format in delete flow of IUD.

    problem : delete flow of IUD is not handling the V3 format feature of pages in the blocklet.
   
    Solution: Adding the page info inside the delete delta file and handling of the same in the query flow.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ravikiran23/incubator-carbondata master-after-iud

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1007.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1007
   
----
commit dba02a0ad6a581f8d4659902a7d1767e6c4b70f5
Author: ravikiran23 <[hidden email]>
Date:   2017-06-02T15:01:57Z

    Adding the Pages support in the Delete Method.

commit 8ac3caa4d8912bf168e199d1b20be2c6937bf9ef
Author: Manohar <[hidden email]>
Date:   2017-06-08T09:50:49Z

    correcting the size of the vector batch excluding the filtered rows.

commit c202faabd496815c415baf82366e4c533c3fd882
Author: joobisb <[hidden email]>
Date:   2017-06-10T15:55:57Z

    changing page id from string to integer.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit commented on the issue:

    https://github.com/apache/carbondata/pull/1007
 
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit commented on the issue:

    https://github.com/apache/carbondata/pull/1007
 
   
    Refer to this link for build results (access rights to CI server needed):
    https://builds.apache.org/job/carbondata-pr-spark-1.6/224/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1007
 
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1007


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---