[GitHub] carbondata pull request #1023: [carbondata-1149] Fix issue of mismatch type ...

[qiuchenjian-2]

GitHub user chenerlu opened a pull request:

    https://github.com/apache/carbondata/pull/1023

    [carbondata-1149] Fix issue of mismatch type of partition column when specify partition info

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chenerlu/incubator-carbondata carbondata-1149-01

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1023.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1023
   
----
commit ff4353a5fbda2ebf4b19b0aafe836195f1ccfb74
Author: chenerlu <[hidden email]>
Date:   2017-06-09T09:33:30Z

    fix issue of carbondata-1149

commit 7321246bbbb69681601eda82a4e40b439f4965b5
Author: chenerlu <[hidden email]>
Date:   2017-06-13T04:06:11Z

    fix issue of carbondata

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit commented on the issue:

    https://github.com/apache/carbondata/pull/1023
 
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit commented on the issue:

    https://github.com/apache/carbondata/pull/1023
 
   
    Refer to this link for build results (access rights to CI server needed):
    https://builds.apache.org/job/carbondata-pr-spark-1.6/303/<h2>Failed Tests: <span class='status-failure'>3</span></h2><h3><a name='carbondata-pr-spark-1.6/org.apache.carbondata:carbondata-spark-common-test' /><a href='https://builds.apache.org/job/carbondata-pr-spark-1.6/303/org.apache.carbondata$carbondata-spark-common-test/testReport'>carbondata-pr-spark-1.6/org.apache.carbondata:carbondata-spark-common-test</a>: <span class='status-failure'>3</span></h3><ul><li><a href='https://builds.apache.org/job/carbondata-pr-spark-1.6/303/org.apache.carbondata$carbondata-spark-common-test/testReport/org.apache.carbondata.spark.testsuite.partition/TestDDLForPartitionTable/create_partition_table__range_partition/'><strong>org.apache.carbondata.spark.testsuite.partition.TestDDLForPartitionTable.create partition table: range partition</strong></a></li><li><a href='https://builds.apache.org/job/carbondata-pr-spark-1.6/303/org.apache.carbondata$carbondata-spark-common-test/testReport/org.apache
 .carbondata.spark.testsuite.partition/TestDDLForPartitionTable/test_exception_when_values_in_list_info_can_not_match_partition_column_type/'><strong>org.apache.carbondata.spark.testsuite.partition.TestDDLForPartitionTable.test exception when values in list_info can not match partition column type</strong></a></li><li><a href='https://builds.apache.org/job/carbondata-pr-spark-1.6/303/org.apache.carbondata$carbondata-spark-common-test/testReport/org.apache.carbondata.spark.testsuite.partition/TestDDLForPartitionTable/test_exception_when_values_in_range_info_can_not_match_partition_column_type/'><strong>org.apache.carbondata.spark.testsuite.partition.TestDDLForPartitionTable.test exception when values in range_info can not match partition column type</strong></a></li></ul>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1023
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2424/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit commented on the issue:

    https://github.com/apache/carbondata/pull/1023
 
   
    Refer to this link for build results (access rights to CI server needed):
    https://builds.apache.org/job/carbondata-pr-spark-1.6/311/<h2>Failed Tests: <span class='status-failure'>1</span></h2><h3><a name='carbondata-pr-spark-1.6/org.apache.carbondata:carbondata-spark-common-test' /><a href='https://builds.apache.org/job/carbondata-pr-spark-1.6/311/org.apache.carbondata$carbondata-spark-common-test/testReport'>carbondata-pr-spark-1.6/org.apache.carbondata:carbondata-spark-common-test</a>: <span class='status-failure'>1</span></h3><ul><li><a href='https://builds.apache.org/job/carbondata-pr-spark-1.6/311/org.apache.carbondata$carbondata-spark-common-test/testReport/org.apache.carbondata.spark.testsuite.partition/TestDDLForPartitionTable/create_partition_table__range_partition/'><strong>org.apache.carbondata.spark.testsuite.partition.TestDDLForPartitionTable.create partition table: range partition</strong></a></li></ul>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1023
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2432/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1023#discussion_r121855817
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala ---
    @@ -179,6 +193,68 @@ object CommonUtil {
         isValid
       }
     
    +  def validateTypeConvert(desType: Option[String], value: String): Boolean = {
    +    var flag = true
    +    val result = desType match {
    +      case Some("IntegerType") =>
    +        DataTypeUtil.getDataBasedOnDataType(value.trim, DataType.INT)
    +      case Some("StringType") =>
    +        DataTypeUtil.getDataBasedOnDataType(value.trim, DataType.STRING)
    +      case Some("LongType") =>
    +        DataTypeUtil.getDataBasedOnDataType(value.trim, DataType.LONG)
    +      case Some("FloatType") =>
    +        DataTypeUtil.getDataBasedOnDataType(value.trim, DataType.FLOAT)
    +      case Some("DoubleType") =>
    +        DataTypeUtil.getDataBasedOnDataType(value.trim, DataType.DOUBLE)
    +      case Some("ByteType") =>
    +        DataTypeUtil.getDataBasedOnDataType(value.trim, DataType.BYTE)
    +      case Some("ShortType") =>
    +        DataTypeUtil.getDataBasedOnDataType(value.trim, DataType.SHORT)
    +      case Some("BooleanType") =>
    +        DataTypeUtil.getDataBasedOnDataType(value.trim, DataType.BOOLEAN)
    +      case Some("DecimalType") =>
    --- End diff --
   
    DecimalType comes with precision and scale like DecimalType(10,0)...so validation for decimal type will fail here....Please correct the validation logic for DecimalType


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1023#discussion_r121863383
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala ---
    @@ -179,6 +193,68 @@ object CommonUtil {
         isValid
       }
     
    +  def validateTypeConvert(desType: Option[String], value: String): Boolean = {
    +    var flag = true
    +    val result = desType match {
    +      case Some("IntegerType") =>
    +        DataTypeUtil.getDataBasedOnDataType(value.trim, DataType.INT)
    +      case Some("StringType") =>
    +        DataTypeUtil.getDataBasedOnDataType(value.trim, DataType.STRING)
    --- End diff --
   
    Please correct me if I am wrong....While validating the values you are trimming the values but in the actual range info can still contain the spaces as the object is not getting refilled with the trimmed values and therefore can lead to an inconsistent state. For e.g I have Int type column with rangeInfo = 1, 2 , 3,4...while parsing it will pass as trim function is used but original object still will have the same values...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user chenerlu commented on the issue:

    https://github.com/apache/carbondata/pull/1023
 
    Duplicated


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user chenerlu closed the pull request at:

    https://github.com/apache/carbondata/pull/1023


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---