Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1084#discussion_r126049777
--- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataPageSource.java ---
@@ -104,27 +104,34 @@ public RecordCursor getCursor()
output.appendNull();
} else {
Type type = types.get(column);
- Class<?> javaType = type.getJavaType();
- if (javaType == boolean.class) {
- type.writeBoolean(output, cursor.getBoolean(column));
- } else if (javaType == long.class) {
- type.writeLong(output, cursor.getLong(column));
- } else if (javaType == double.class) {
- type.writeDouble(output, cursor.getDouble(column));
- } else if (javaType == Slice.class) {
- Slice slice = cursor.getSlice(column);
- if(type instanceof DecimalType)
- {
- if (isShortDecimal(type)) {
- type.writeLong(output, parseLong((DecimalType) type, slice, 0, slice.length()));
+
+ String base = type.getTypeSignature().getBase();
+ switch(base) {
+ case "varchar":
+ case "decimal": Slice slice = cursor.getSlice(column);
+ if(type instanceof DecimalType)
+ {
--- End diff --
move `{` to previous line.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at
[hidden email] or file a JIRA ticket
with INFRA.
---
Locked
