[GitHub] carbondata pull request #1113: [CARBONDATA-1246] fix null pointer exception ...

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1113: [CARBONDATA-1246] fix null pointer exception ...

qiuchenjian-2
GitHub user ray6080 opened a pull request:

    https://github.com/apache/carbondata/pull/1113

    [CARBONDATA-1246] fix null pointer exception by changing null to empty array

    In presto integration, `CarbonFile.listFiles()` function will return null when the specified `fileStatus` is not a directory or is null. This will incur a `NullPointerException` when called by `CarbonTableReader.updateTableList()` function.
    Change the `listFiles()` function to return an empty array, instead of a null value.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ray6080/carbondata master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1113.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1113
   
----
commit e9e1fa7ad40f38103a7a0572ce58c49a1c1f6365
Author: Jin Guodong <[hidden email]>
Date:   2017-06-29T04:43:51Z

    fix null pointer exception by changing null to empty array

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1113: [CARBONDATA-1246] fix null pointer exception by chan...

qiuchenjian-2
Github user asfgit commented on the issue:

    https://github.com/apache/carbondata/pull/1113
 
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1113: [CARBONDATA-1246] fix null pointer exception by chan...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1113
 
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1113: [CARBONDATA-1246] fix null pointer exception by chan...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1113
 
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1113: [CARBONDATA-1246] fix null pointer exception by chan...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit commented on the issue:

    https://github.com/apache/carbondata/pull/1113
 
   
    Refer to this link for build results (access rights to CI server needed):
    https://builds.apache.org/job/carbondata-pr-spark-1.6/719/<h2>Failed Tests: <span class='status-failure'>4</span></h2><h3><a name='carbondata-pr-spark-1.6/org.apache.carbondata:carbondata-core' /><a href='https://builds.apache.org/job/carbondata-pr-spark-1.6/719/org.apache.carbondata$carbondata-core/testReport'>carbondata-pr-spark-1.6/org.apache.carbondata:carbondata-core</a>: <span class='status-failure'>4</span></h3><ul><li><a href='https://builds.apache.org/job/carbondata-pr-spark-1.6/719/org.apache.carbondata$carbondata-core/testReport/org.apache.carbondata.core.datastore.filesystem/AlluxioCarbonFileTest/testListFilesWithOutDirectoryPermission/'><strong>org.apache.carbondata.core.datastore.filesystem.AlluxioCarbonFileTest.testListFilesWithOutDirectoryPermission</strong></a></li><li><a href='https://builds.apache.org/job/carbondata-pr-spark-1.6/719/org.apache.carbondata$carbondata-core/testReport/org.apache.carbondata.core.datastore.filesystem/HDFSCarbonFileTest/testListFilesW
 ithOutDirectoryPermission/'><strong>org.apache.carbondata.core.datastore.filesystem.HDFSCarbonFileTest.testListFilesWithOutDirectoryPermission</strong></a></li><li><a href='https://builds.apache.org/job/carbondata-pr-spark-1.6/719/org.apache.carbondata$carbondata-core/testReport/org.apache.carbondata.core.datastore.filesystem/LocalCarbonFileTest/testListFilesWithOutDirPermission/'><strong>org.apache.carbondata.core.datastore.filesystem.LocalCarbonFileTest.testListFilesWithOutDirPermission</strong></a></li><li><a href='https://builds.apache.org/job/carbondata-pr-spark-1.6/719/org.apache.carbondata$carbondata-core/testReport/org.apache.carbondata.core.datastore.filesystem/ViewFsCarbonFileTest/testListFilesWithOutDirectoryPermission/'><strong>org.apache.carbondata.core.datastore.filesystem.ViewFsCarbonFileTest.testListFilesWithOutDirectoryPermission</strong></a></li></ul>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1113: [CARBONDATA-1246] fix null pointer exception by chan...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit commented on the issue:

    https://github.com/apache/carbondata/pull/1113
 
   
    Refer to this link for build results (access rights to CI server needed):
    https://builds.apache.org/job/carbondata-pr-spark-1.6/720/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1113: [CARBONDATA-1246] fix null pointer exception by chan...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user gvramana commented on the issue:

    https://github.com/apache/carbondata/pull/1113
 
    retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1113: [CARBONDATA-1246] fix null pointer exception by chan...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1113
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2906/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1113: [CARBONDATA-1246] fix null pointer exception by chan...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1113
 
    Build Success with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder/320/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1113: [CARBONDATA-1246] fix null pointer exception by chan...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user gvramana commented on the issue:

    https://github.com/apache/carbondata/pull/1113
 
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1113: [CARBONDATA-1246] fix null pointer exception ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1113


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---