[GitHub] carbondata pull request #1116: [CARBONDATA-1249] Wrong order of columns i n ...

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1116
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1476/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1116
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1539/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1116
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1940/



---

[qiuchenjian-2]

Github user sraghunandan commented on the issue:

    https://github.com/apache/carbondata/pull/1116
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1116
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/870/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1116
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2095/



---

[qiuchenjian-2]

Github user mohammadshahidkhan commented on the issue:

    https://github.com/apache/carbondata/pull/1116
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1116
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/896/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1116
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2121/



---

[qiuchenjian-2]

Github user sraghunandan commented on the issue:

    https://github.com/apache/carbondata/pull/1116
 
    please add test case to validate this scenario


---

[qiuchenjian-2]

Github user mohammadshahidkhan commented on the issue:

    https://github.com/apache/carbondata/pull/1116
 
    added test case to validate the scenario


---

[qiuchenjian-2]

Github user sounakr commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1116#discussion_r158022240
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java ---
    @@ -622,4 +624,30 @@ public static String trimErrorMessage(String input) {
         }
         return errorMessage;
       }
    +  /**
    +   * The method returns true is either logger is enabled or action is redirect
    +   * @param configuration
    +   * @return
    +   */
    +  public static boolean isRawDataRequired(CarbonDataLoadConfiguration configuration) {
    +    boolean isRawDataRequired = Boolean.parseBoolean(
    +        configuration.getDataLoadProperty(DataLoadProcessorConstants.BAD_RECORDS_LOGGER_ENABLE)
    +            .toString());
    +    // if logger is disabled then check if action is redirect then raw data will be required.
    +    if (!isRawDataRequired) {
    --- End diff --
   
    Is isRawDataRequired is needed only in the case of LoggerAction.REDIRECT.  In that scenario we can turn ON isRawDataRequired whenever LoggerAction.REDIRECT is true. Why to keep a separate configuration?


---

[qiuchenjian-2]

Github user mohammadshahidkhan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1116#discussion_r158028051
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java ---
    @@ -622,4 +624,30 @@ public static String trimErrorMessage(String input) {
         }
         return errorMessage;
       }
    +  /**
    +   * The method returns true is either logger is enabled or action is redirect
    +   * @param configuration
    +   * @return
    +   */
    +  public static boolean isRawDataRequired(CarbonDataLoadConfiguration configuration) {
    +    boolean isRawDataRequired = Boolean.parseBoolean(
    +        configuration.getDataLoadProperty(DataLoadProcessorConstants.BAD_RECORDS_LOGGER_ENABLE)
    +            .toString());
    +    // if logger is disabled then check if action is redirect then raw data will be required.
    +    if (!isRawDataRequired) {
    --- End diff --
   
    It is needed for the cases bad record logger is enabled or action is redirect.
    No new configuration introduce? Just preparing a flag from existing configuration.


---

[qiuchenjian-2]

Github user sounakr commented on the issue:

    https://github.com/apache/carbondata/pull/1116
 
    LGTM


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1116
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2457/



---

[qiuchenjian-2]

Github user mohammadshahidkhan commented on the issue:

    https://github.com/apache/carbondata/pull/1116
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1116
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/983/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1116
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2206/



---

[qiuchenjian-2]

Github user mohammadshahidkhan commented on the issue:

    https://github.com/apache/carbondata/pull/1116
 
    retest sdv please


---

[qiuchenjian-2]

Github user mohammadshahidkhan commented on the issue:

    https://github.com/apache/carbondata/pull/1116
 
    retest this please


---