[GitHub] carbondata pull request #1125: [CarbonData-1250] change default partition id...

[qiuchenjian-2]

Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1125#discussion_r126876373
 
    --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java ---
    @@ -266,26 +264,22 @@ private static AbsoluteTableIdentifier getAbsoluteTableIdentifier(Configuration
           // process and resolve the expression
           Expression filter = getFilterPredicates(job.getConfiguration());
           CarbonTable carbonTable = getCarbonTable(job.getConfiguration());
    +      PartitionInfo partitionInfo = carbonTable.getPartitionInfo(carbonTable.getFactTableName());
    --- End diff --
   
    please move code  to 274 line.
    Variable carbonTable should be checked before it was used.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1125#discussion_r126876084
 
    --- Diff: format/src/main/thrift/schema.thrift ---
    @@ -132,9 +132,12 @@ struct SchemaEvolution{
     struct PartitionInfo{
         1: required list<ColumnSchema> partition_columns;
         2: required PartitionType partition_type;
    -    3: optional i32 num_partitions;  // number of partitions defined in hash partition table
    +    3: optional i32 hash_number;  // number of partitions defined in hash partition table
         4: optional list<list<string>> list_info; // value list of list partition table
         5: optional list<string> range_info;  // range value list of range partition table
    +    6: optional list<i32> partitionIdList; // partition Id list
    --- End diff --
   
    change the name to partition_ids


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1125#discussion_r126875952
 
    --- Diff: format/src/main/thrift/schema.thrift ---
    @@ -132,9 +132,12 @@ struct SchemaEvolution{
     struct PartitionInfo{
         1: required list<ColumnSchema> partition_columns;
         2: required PartitionType partition_type;
    -    3: optional i32 num_partitions;  // number of partitions defined in hash partition table
    +    3: optional i32 hash_number;  // number of partitions defined in hash partition table
    --- End diff --
   
    please keep num_partitions


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1125#discussion_r126876163
 
    --- Diff: format/src/main/thrift/schema.thrift ---
    @@ -132,9 +132,12 @@ struct SchemaEvolution{
     struct PartitionInfo{
         1: required list<ColumnSchema> partition_columns;
         2: required PartitionType partition_type;
    -    3: optional i32 num_partitions;  // number of partitions defined in hash partition table
    +    3: optional i32 hash_number;  // number of partitions defined in hash partition table
         4: optional list<list<string>> list_info; // value list of list partition table
         5: optional list<string> range_info;  // range value list of range partition table
    +    6: optional list<i32> partitionIdList; // partition Id list
    +    7: optional i32 numOfPartitions;  // total partition count
    +    8: optional i32 max_partition;  // max task id for now
    --- End diff --
   
    what is it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1125#discussion_r126874942
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/PartitionInfo.java ---
    @@ -43,13 +44,30 @@
       private List<List<String>> listInfo;
     
       /**
    -   * number of partitions
    +   * number of hash partitions
        */
    -  private int numPartitions;
    +  private int hashNumber;
    +
    +  /**
    +   * total count of partitions
    +   */
    +  private int numberOfPartitions;
    --- End diff --
   
    not require hashNumber, numberOfPartitions is enough.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1125
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/3042/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1125
 
    Build Failed with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder/454/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1125
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/3044/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1125
 
    Build Failed with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder/457/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user QiangCai commented on the issue:

    https://github.com/apache/carbondata/pull/1125
 
    Local Verification pass
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1125


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---